RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2024-12-24 02:32:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Emit reports about not-yet categorized diff nodes

Browse Source 
* include/abg-comparison.h (NO_CHANGE_CATEGORY): Better comment
	this enumerator.
	* src/abg-comparison.cc (diff::is_filtered_out): Not-yet
	categorized changes are not filtered out anymore.
	(distinct_diff::report): Avoid extraneous new line here.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2014-09-16 15:14:35 +02:00
parent fde3436568
commit 5bce089f23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/abg-comparison.h
View File

@ -230,7 +230,8 @@ public:
/// into, regarding the kind of changes it represents. /// into, regarding the kind of changes it represents.
enum diff_category enum diff_category
{ {
/// This means the diff node does not carry any (meaningful) change. /// This means the diff node does not carry any (meaningful) change,
/// or that it carries changes that have not yet been categorized.
NO_CHANGE_CATEGORY = 0, NO_CHANGE_CATEGORY = 0,
/// This means the diff node is *NOT* redundant. The reason why we /// This means the diff node is *NOT* redundant. The reason why we

8
src/abg-comparison.cc
View File

@ -812,6 +812,9 @@ diff::is_filtered_out() const
if (!(get_category() & NOT_REDUNDANT_CATEGORY)) if (!(get_category() & NOT_REDUNDANT_CATEGORY))
return true; return true;
if (get_category() == NO_CHANGE_CATEGORY)
return false;
// Ignore the NOT_REDUNDANT_CATEGORY bit when comparing allowed // Ignore the NOT_REDUNDANT_CATEGORY bit when comparing allowed
// categories and the current set of categories. // categories and the current set of categories.
return !((get_category() & ~NOT_REDUNDANT_CATEGORY) return !((get_category() & ~NOT_REDUNDANT_CATEGORY)
@ -945,11 +948,8 @@ distinct_diff::report(ostream& out, const string& indent) const
assert(diff->to_be_reported()); assert(diff->to_be_reported());
diff->report(out, indent + " "); diff->report(out, indent + " ");
} }
else
if (!report_size_and_alignment_changes(f, s, context(), out, indent, true))
out << indent << "but no size changed\n";
else else
out << "\n"; report_size_and_alignment_changes(f, s, context(), out, indent, true);
} }
/// Traverse an instance of distinct_diff. /// Traverse an instance of distinct_diff.