RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2024-12-16 06:54:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

comparison: When marking leaf nodes don't do unnecessary impact analysis

Browse Source 
When marking leaf nodes, if interface impact analysis is not required,
then avoid visiting the same diff node twice when walking the diff
graph.  Allowing to visit the same diff node twice would be useful so
that the sub-graph of each interface diff node would be walked in full
to determine the impact of each leaf diff node on each interface.  But
if such impact analysis is not required, then we can just visit each
diff graph node once and speed up things greatly in leaf node
reporting mode.

	* src/abg-comparison.cc (corpus_diff::mark_leaf_diff_nodes): If
	impact analysis is not required, visit each node just once.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2023-02-16 12:33:02 +01:00
parent 82f50f2093
commit 4e58cdaba6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/abg-comparison.cc
View File

@ -11230,7 +11230,8 @@ corpus_diff::mark_leaf_diff_nodes()
context()->forget_visited_diffs();
bool s = context()->visiting_a_node_twice_is_forbidden();
context()->forbid_visiting_a_node_twice(true);
context()->forbid_visiting_a_node_twice_per_interface(true);
if (context()->show_impacted_interfaces())
context()->forbid_visiting_a_node_twice_per_interface(true);
traverse(v);
context()->forbid_visiting_a_node_twice(s);
context()->forbid_visiting_a_node_twice_per_interface(false);