RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2025-02-02 06:41:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pass a bunch of parameters by reference as they ought to be

Browse Source 
* include/abg-ir.h (operator==): In the overload for
	elf_symbol_sptr, pass the parameters by reference.
	* src/abg-ir.cc (operator==): Do the same at definition site.
	* src/abg-comparison.cc (maybe_report_diff_for_member): Pass
	parameters by reference.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2015-11-07 23:04:01 +01:00
parent 7b35e89315
commit 4adbafaa43
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/abg-ir.h
View File

@ -646,7 +646,7 @@ bool
string_to_elf_symbol_binding(const string&, elf_symbol::binding&);
bool
operator==(const elf_symbol_sptr lhs, const elf_symbol_sptr rhs);
operator==(const elf_symbol_sptr& lhs, const elf_symbol_sptr& rhs);
bool
elf_symbols_alias(const elf_symbol& s1, const elf_symbol& s2);

20
src/abg-comparison.cc
View File

@ -6245,11 +6245,11 @@ get_pretty_representation(diff* d)
}
static bool
maybe_report_diff_for_member(decl_base_sptr decl1,
decl_base_sptr decl2,
diff_context_sptr ctxt,
ostream& out,
const string& indent);
maybe_report_diff_for_member(const decl_base_sptr& decl1,
const decl_base_sptr& decl2,
const diff_context_sptr& ctxt,
ostream& out,
const string& indent);
/// Stream a string representation for a member function.
///
@ -6899,11 +6899,11 @@ compute_diff(const var_decl_sptr first,
///
/// @return true if something was reported, false otherwise.
static bool
maybe_report_diff_for_member(decl_base_sptr decl1,
decl_base_sptr decl2,
diff_context_sptr ctxt,
ostream& out,
const string& indent)
maybe_report_diff_for_member(const decl_base_sptr& decl1,
const decl_base_sptr& decl2,
const diff_context_sptr& ctxt,
ostream& out,
const string& indent)
{
bool reported = false;

2
src/abg-ir.cc
View File

@ -1315,7 +1315,7 @@ elf_symbol::does_alias(const elf_symbol& o) const
}
bool
operator==(const elf_symbol_sptr lhs, const elf_symbol_sptr rhs)
operator==(const elf_symbol_sptr& lhs, const elf_symbol_sptr& rhs)
{
if (!!lhs != !!rhs)
return false;