RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2025-03-08 07:38:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Lookup proper names of symbol during determination of deleted/added decls

Browse Source 
* src/abg-comparison.cc
	({class,corpus}_diff::ensure_lookup_tables_populated):  Now that in the
	intermediate maps we store symbol *ids* rather than symbol names,
	make sure to really refer to symbol names for symbol lookups,
	rather than (wrongly) referring to symbol ids.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2014-08-27 11:37:50 +02:00
parent e5490e206b
commit 495a1dba55
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/abg-comparison.cc
View File

@ -3302,9 +3302,13 @@ class_diff::ensure_lookup_tables_populated(void) const
deleted_member_fns().begin();
i != deleted_member_fns().end();
++i)
if (s->lookup_function_symbol(i->first))
// We assume that all the functions we look at here have ELF
// symbols.
if (s->lookup_function_symbol(i->second->get_symbol()->get_name(),
i->second->get_symbol()->get_version().str()))
to_delete.push_back(i->first);
for (vector<string>::const_iterator i = to_delete.begin();
i != to_delete.end();
++i)
@ -3317,7 +3321,8 @@ class_diff::ensure_lookup_tables_populated(void) const
inserted_member_fns().begin();
i != inserted_member_fns().end();
++i)
if (f->lookup_function_symbol(i->first))
if (f->lookup_function_symbol(i->second->get_symbol()->get_name(),
i->second->get_symbol()->get_version().str()))
to_delete.push_back(i->first);
for (vector<string>::const_iterator i = to_delete.begin();
@ -6242,7 +6247,7 @@ corpus_diff::priv::ensure_lookup_tables_populated()
for (string_function_ptr_map::const_iterator i = deleted_fns_.begin();
i != deleted_fns_.end();
++i)
if (second_->lookup_function_symbol(i->first,
if (second_->lookup_function_symbol(i->second->get_symbol()->get_name(),
i->second->get_symbol()->get_version().str()))
to_delete.push_back(i->first);
@ -6257,7 +6262,7 @@ corpus_diff::priv::ensure_lookup_tables_populated()
for (string_function_ptr_map::const_iterator i = added_fns_.begin();
i != added_fns_.end();
++i)
if (first_->lookup_function_symbol(i->first,
if (first_->lookup_function_symbol(i->second->get_symbol()->get_name(),
i->second->get_symbol()->get_version().str()))
to_delete.push_back(i->first);
@ -6327,7 +6332,7 @@ corpus_diff::priv::ensure_lookup_tables_populated()
for (string_var_ptr_map::const_iterator i = deleted_vars_.begin();
i != deleted_vars_.end();
++i)
if (second_->lookup_variable_symbol(i->first,
if (second_->lookup_variable_symbol(i->second->get_symbol()->get_name(),
i->second->get_symbol()->get_version().str()))
to_delete.push_back(i->first);
@ -6342,7 +6347,7 @@ corpus_diff::priv::ensure_lookup_tables_populated()
for (string_var_ptr_map::const_iterator i = added_vars_.begin();
i != added_vars_.end();
++i)
if (first_->lookup_variable_symbol(i->first,
if (first_->lookup_variable_symbol(i->second->get_symbol()->get_name(),
i->second->get_symbol()->get_version().str()))
to_delete.push_back(i->first);