RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2024-12-14 22:14:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

dwarf-reader: handle binaries with missing symtab

Browse Source 
A broken elf file might not have a valid symtab. As of now we would hit
an ABG_ASSERT and crash. Let's catch that case and bail out instead.

        * src/abg-dwarf-reader.cc (load_symbol_maps_from_symtab_section):
        Handle elf file with missing symtab.
        * tests/test-read-dwarf.cc (InOutSpec): add test case.
        * tests/data/test-read-dwarf/test26-bogus-binary.elf: new test data.

Signed-off-by: Matthias Maennich <maennich@google.com>
This commit is contained in:
Matthias Maennich 2020-01-25 21:40:14 +00:00
parent 4252dfd6c5
commit 4457c10eec
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/abg-dwarf-reader.cc
View File

@ -7396,7 +7396,8 @@ public:
size_t nb_syms = symtab_sheader->sh_size / symtab_sheader->sh_entsize; size_t nb_syms = symtab_sheader->sh_size / symtab_sheader->sh_entsize;
Elf_Data* symtab = elf_getdata(symtab_section, 0); Elf_Data* symtab = elf_getdata(symtab_section, 0);
ABG_ASSERT(symtab); if (!symtab)
return false;
GElf_Ehdr elf_header; GElf_Ehdr elf_header;
ABG_ASSERT(gelf_getehdr(elf_handle(), &elf_header)); ABG_ASSERT(gelf_getehdr(elf_handle(), &elf_header));

BIN
tests/data/test-read-dwarf/test26-bogus-binary.elf Normal file
View File

Binary file not shown.

6
tests/test-read-dwarf.cc
View File

@ -259,6 +259,12 @@ InOutSpec in_out_specs[] =
"", "",
"", "",
}, },
{
"data/test-read-dwarf/test26-bogus-binary.elf",
"",
"",
"",
},
// This should be the last entry. // This should be the last entry.
{NULL, NULL, NULL, NULL} {NULL, NULL, NULL, NULL}
}; };