RepoMirrors
/
libabigail
mirror of git://sourceware.org/git/libabigail.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

btf-reader: Fix re-use of the BTF reader for several binaries in a row 

When analyzing a Linux Kernel tree, the BTF reader needs to be reset
after each binary (vmlinux or module) read.  It turns out the reset
was not being done properly.  Fixed thus.  Also, I noticed that
reader::read_debug_info_into_corpus would not return an empty corpus
when no BTF information was found in the binary.  Fixed as well.

	* src/abg-btf-reader.cc (reader::initialize): Free the btf handle
	first thing as part of the re-initialization.
	(reader::~reader): Once the BTF handle has been freed, set it to
	nil to show that it's been deleted.
	(reader::read_debug_info_into_corpus): If no BTF handle could be
	retrieved then it means no BTF data was found on the binary.
	Thus, return an empty corpus.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2024-05-31 15:29:48 +02:00
parent 416df074a8
commit 19a4ae130d
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/abg-btf-reader.cc
View File

@ -238,8 +238,9 @@ protected:
bool load_all_types,
bool linux_kernel_mode)
{
elf_based_reader::initialize(elf_path, debug_info_root_paths);
btf__free(btf_handle_);
btf_handle_ = nullptr;
elf_based_reader::initialize(elf_path, debug_info_root_paths);
options().load_all_types = load_all_types;
options().load_in_linux_kernel_mode = linux_kernel_mode;
}
@ -305,6 +306,7 @@ public:
~reader()
{
btf__free(btf_handle_);
btf_handle_ = nullptr;
}
/// Read the ELF information as well as the BTF type information to
@ -346,7 +348,8 @@ public:
corpus_sptr
read_debug_info_into_corpus()
{
btf_handle();
if (!btf_handle())
return corpus_sptr();
translation_unit_sptr artificial_tu
(new translation_unit(env(), "", /*address_size=*/64));