RepoMirrors
/
libabigail
mirror of git://sourceware.org/git/libabigail.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix enum_diff::has_changes() 

Now that we have type canonicalizing, there is no need for trying to
be smart when comparing types; just do the comparison and it should be
fast.  Plus in the case of enum_diff, we just getting it wrong as we were
not checking several parts of the enum type, like the member access
specifiers if it was a member type, etc ...

	* src/abg-comparison.cc (enum_diff::has_changes): Just use the
	normal comparison operator to compare the two enums here.  It's
	fast now.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2015-02-24 12:35:52 +01:00
parent dc2f054d03
commit 14607415fb
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/abg-comparison.cc
View File

@ -5895,12 +5895,7 @@ enum_diff::get_pretty_representation() const
/// @return true iff the current diff node carries a change.
bool
enum_diff::has_changes() const
{
bool a, b;
a = underlying_type_diff() ? underlying_type_diff()->has_changes() : false;
b = priv_->enumerators_changes_.length();
return a || b;
}
{return first_enum() != second_enum();}
/// @return true iff the current diff node carries local changes.
bool