2016-01-15 12:34:16 +00:00
|
|
|
// -*- Mode: C++ -*-
|
|
|
|
//
|
2020-02-21 15:42:35 +00:00
|
|
|
// Copyright (C) 2013-2020 Red Hat, Inc.
|
2016-01-15 12:34:16 +00:00
|
|
|
//
|
|
|
|
// This file is part of the GNU Application Binary Interface Generic
|
|
|
|
// Analysis and Instrumentation Library (libabigail). This library is
|
|
|
|
// free software; you can redistribute it and/or modify it under the
|
|
|
|
// terms of the GNU Lesser General Public License as published by the
|
|
|
|
// Free Software Foundation; either version 3, or (at your option) any
|
|
|
|
// later version.
|
|
|
|
|
|
|
|
// This library is distributed in the hope that it will be useful, but
|
|
|
|
// WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
// General Lesser Public License for more details.
|
|
|
|
|
|
|
|
// You should have received a copy of the GNU Lesser General Public
|
|
|
|
// License along with this program; see the file COPYING-LGPLV3. If
|
|
|
|
// not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
|
|
// Author: Dodji Seketeli
|
|
|
|
|
|
|
|
/// @file
|
|
|
|
///
|
|
|
|
/// This file declares an interface for the worker threads (or thread
|
|
|
|
/// pool) design pattern. It aims at performing a set of tasks in
|
|
|
|
/// parallel, using the multi-threading capabilities of the underlying
|
|
|
|
/// processor(s).
|
|
|
|
///
|
|
|
|
|
|
|
|
#ifndef __ABG_WORKERS_H__
|
|
|
|
#define __ABG_WORKERS_H__
|
|
|
|
|
|
|
|
#include <vector>
|
2019-07-05 11:00:23 +00:00
|
|
|
#include "abg-cxx-compat.h"
|
2016-01-15 12:34:16 +00:00
|
|
|
|
2019-07-05 11:00:23 +00:00
|
|
|
using abg_compat::shared_ptr;
|
2016-01-15 12:34:16 +00:00
|
|
|
|
|
|
|
namespace abigail
|
|
|
|
{
|
2016-04-27 12:29:07 +00:00
|
|
|
|
|
|
|
/// The namespace of the worker threads (or thread pool)
|
|
|
|
/// implementation of libabigail. This was modelled after the article
|
|
|
|
/// https://en.wikipedia.org/wiki/Thread_pool.
|
2016-01-15 12:34:16 +00:00
|
|
|
namespace workers
|
|
|
|
{
|
|
|
|
|
|
|
|
size_t get_number_of_threads();
|
|
|
|
|
2016-04-27 12:29:07 +00:00
|
|
|
/// This represents a task to be performed.
|
|
|
|
///
|
|
|
|
/// Each instance of this type represents a task that can be performed
|
|
|
|
/// concurrently to other instance of the same type.
|
|
|
|
///
|
|
|
|
/// An instance of @ref task is meant to be performed by a worker
|
|
|
|
/// (thread). A set of tasks can be stored in a @ref queue.
|
2016-01-15 12:34:16 +00:00
|
|
|
class task
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
virtual void
|
|
|
|
perform() = 0;
|
|
|
|
|
abg-workers: Rework the worker queue to improve concurrent behaviour
This patch refactors the abigail::workers::queue and
abigail::workers::worker implementations to avoid holding locking
primitives longer than necessary.
In particular, the queue_cond_mutex was held during the entiry worker
runtime, effectively serializing the workers. Hence, use a mutex+cond
pair for each, the input and output queue and only synchronize around
the interaction with their corresponding queues. The
tasks_todo_(mutex|cond) are meant to synchronize scheduling and
distribution of work among workers, while tasks_done_(mutex|cond) are
used for synchronizing threads when putting back the tasks to the output
queue and to hold back threads waiting for the queue and workers to
drain.
Along that way, I did some cleanup that was now possible.
- Move entire implementation of abigail::workers::task into header.
- Make default_notify a static member.
- Replace the multiple constructors with one with default arguments.
* include/abg-workers.h (workers::task): move entire
implementation to header and drop superfluous forward declaration.
* src/abg-workers.cc (workers::task):: Likewise.
(workers::queue::priv): Drop queue_cond_mutex, rename queue_cond
to tasks_todo_cond, add task_done_cond, make default_notify
static.
(workers::queue::priv::priv): Add default arguments to fully
qualified constructor, drop the remaining ones.
(workers::queue:prive::more_tasks_to_execute): Drop method.
(workers::queue:prive::schedule_task): Do not synchronize access
to the queue condition variable, but only on the mutex.
(do_bring_workers_down): Likewise. Also await tasks_done to be
empty.
(workers::queue:prive::worker::wait_to_execute_a_task): Await
tasks on the tasks_todo with tasks_todo_(cond|mutex) and signal
task completion to tasks_done_cond.
Signed-off-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
2020-02-04 13:05:49 +00:00
|
|
|
virtual ~task(){};
|
2016-01-15 12:34:16 +00:00
|
|
|
}; // end class task.
|
|
|
|
|
abg-workers: Rework the worker queue to improve concurrent behaviour
This patch refactors the abigail::workers::queue and
abigail::workers::worker implementations to avoid holding locking
primitives longer than necessary.
In particular, the queue_cond_mutex was held during the entiry worker
runtime, effectively serializing the workers. Hence, use a mutex+cond
pair for each, the input and output queue and only synchronize around
the interaction with their corresponding queues. The
tasks_todo_(mutex|cond) are meant to synchronize scheduling and
distribution of work among workers, while tasks_done_(mutex|cond) are
used for synchronizing threads when putting back the tasks to the output
queue and to hold back threads waiting for the queue and workers to
drain.
Along that way, I did some cleanup that was now possible.
- Move entire implementation of abigail::workers::task into header.
- Make default_notify a static member.
- Replace the multiple constructors with one with default arguments.
* include/abg-workers.h (workers::task): move entire
implementation to header and drop superfluous forward declaration.
* src/abg-workers.cc (workers::task):: Likewise.
(workers::queue::priv): Drop queue_cond_mutex, rename queue_cond
to tasks_todo_cond, add task_done_cond, make default_notify
static.
(workers::queue::priv::priv): Add default arguments to fully
qualified constructor, drop the remaining ones.
(workers::queue:prive::more_tasks_to_execute): Drop method.
(workers::queue:prive::schedule_task): Do not synchronize access
to the queue condition variable, but only on the mutex.
(do_bring_workers_down): Likewise. Also await tasks_done to be
empty.
(workers::queue:prive::worker::wait_to_execute_a_task): Await
tasks on the tasks_todo with tasks_todo_(cond|mutex) and signal
task completion to tasks_done_cond.
Signed-off-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
2020-02-04 13:05:49 +00:00
|
|
|
typedef shared_ptr<task> task_sptr;
|
|
|
|
|
2016-04-27 12:29:07 +00:00
|
|
|
/// This represents a queue of tasks to be performed.
|
|
|
|
///
|
|
|
|
/// Tasks are performed by a number of worker threads.
|
|
|
|
///
|
|
|
|
/// When a task is inserted into a @ref queue, the task is said to be
|
|
|
|
/// "scheduled for execution".
|
|
|
|
///
|
|
|
|
/// This is because there are worker threads waiting for tasks to be
|
|
|
|
/// added to the queue. When a task is added to the queue, a worker
|
|
|
|
/// thread picks it up, executes it, notifies interested listeners
|
|
|
|
/// when the @ref task's execution is completed, and waits for another
|
|
|
|
/// task to be added to the queue.
|
|
|
|
///
|
|
|
|
/// Of course, several worker threads can execute tasks concurrently.
|
2016-01-15 12:34:16 +00:00
|
|
|
class queue
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
struct priv;
|
|
|
|
typedef shared_ptr<priv> priv_sptr;
|
|
|
|
|
2017-02-24 09:58:16 +00:00
|
|
|
/// A convenience typedef for a vector of @ref task_sptr
|
|
|
|
typedef std::vector<task_sptr> tasks_type;
|
|
|
|
|
2016-01-15 12:34:16 +00:00
|
|
|
private:
|
|
|
|
priv_sptr p_;
|
|
|
|
|
|
|
|
public:
|
|
|
|
struct task_done_notify;
|
|
|
|
queue();
|
|
|
|
queue(unsigned number_of_workers);
|
|
|
|
queue(unsigned number_of_workers,
|
2017-02-24 09:58:16 +00:00
|
|
|
task_done_notify& notifier);
|
2016-01-15 12:34:16 +00:00
|
|
|
size_t get_size() const;
|
|
|
|
bool schedule_task(const task_sptr&);
|
2017-02-24 09:58:16 +00:00
|
|
|
bool schedule_tasks(const tasks_type&);
|
2016-01-15 12:34:16 +00:00
|
|
|
void wait_for_workers_to_complete();
|
2017-02-24 09:58:16 +00:00
|
|
|
tasks_type& get_completed_tasks() const;
|
2016-01-15 12:34:16 +00:00
|
|
|
~queue();
|
|
|
|
}; // end class queue
|
|
|
|
|
2016-04-27 12:29:07 +00:00
|
|
|
/// This functor is to notify listeners that a given task scheduled
|
|
|
|
/// for execution has been fully executed.
|
2016-01-15 12:34:16 +00:00
|
|
|
struct queue::task_done_notify
|
|
|
|
{
|
|
|
|
virtual void
|
|
|
|
operator()(const task_sptr& task_done);
|
|
|
|
};
|
|
|
|
} // end namespace workers
|
|
|
|
} // end namespace abigail
|
|
|
|
#endif // __ABG_WORKERS_H__
|