RepoMirrors/kpatch
1
0
Fork 0
mirror of https://github.com/dynup/kpatch synced 2024-12-26 07:12:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

support for calling a new function in another object

Browse Source 
If a patch adds a new function in foo.c, and calls that function from
bar.c, currently it fails with something like:

    kpatch_create_dynamic_rela_sections: 2115: lookup_global_symbol failed for tpe_allow_file, needed for .text.do_mmap_pgoff

This (crudely) fixes the issue by assuming that if we can't find the
global symbol in the original vmlinux, that it will be provided by
another object in the patch module.  If that assumption is incorrect,
the module will fail to load due to the missing symbol dependency.

A (perhaps) better way to fix this is to search for the symbol in the
patched version of the vmlinux.  But I think this approach is good
enough, for now at least.

Fixes #388.
This commit is contained in:
Josh Poimboeuf 2014-09-02 09:59:22 -05:00
parent b369d4852a
commit f257de7c77
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kpatch-build/create-diff-object.c
View File

@ -2106,11 +2106,15 @@ void kpatch_create_dynamic_rela_sections(struct kpatch_elf *kelf,
*/
if (lookup_is_exported_symbol(table, rela->sym->name))
continue;
/*
* If lookup_global_symbol() fails, assume the
* symbol is defined in another object in the
* patch module.
*/
if (lookup_global_symbol(table, rela->sym->name,
&result))
ERROR("lookup_global_symbol failed for %s, needed for %s\n",
rela->sym->name,
sec->base->name);
continue;
} else {
/*
* We have a patch to a module which references