RepoMirrors/kpatch
1
0
Fork 0
mirror of https://github.com/dynup/kpatch synced 2025-04-07 01:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

kpatch-elf: pass new ELF output file mode to kpatch_write_output_elf()

Browse Source 
Currently all the callers of kpatch_write_output_elf() are creating
.o object files or .ko kernel modules.  Neither of these filetypes are
executable on their own, so enhance kpatch_write_output_elf() to accept
file creation mode and update its callers to pass 0664 to match
the expected permissions.

Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
This commit is contained in:
Joe Lawrence 2020-09-24 17:46:45 -04:00
parent f5c165a722
commit ef420050e3
5 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kpatch-build/create-diff-object.c
View File

@ -3796,7 +3796,7 @@ int main(int argc, char *argv[])
kpatch_create_strtab(kelf_out);
kpatch_create_symtab(kelf_out);
kpatch_dump_kelf(kelf_out);
kpatch_write_output_elf(kelf_out, kelf_patched->elf, output_obj);
kpatch_write_output_elf(kelf_out, kelf_patched->elf, output_obj, 0664);
lookup_close(lookup);
kpatch_elf_free(kelf_patched);

2
kpatch-build/create-klp-module.c
View File

@ -503,7 +503,7 @@ int main(int argc, char *argv[])
kpatch_create_strtab(kelf);
kpatch_create_symtab(kelf);
kpatch_write_output_elf(kelf, kelf->elf, arguments.args[1]);
kpatch_write_output_elf(kelf, kelf->elf, arguments.args[1], 0664);
kpatch_elf_teardown(kelf);
kpatch_elf_free(kelf);

2
kpatch-build/create-kpatch-module.c
View File

@ -257,7 +257,7 @@ int main(int argc, char *argv[])
kpatch_create_strtab(kelf);
kpatch_create_symtab(kelf);
kpatch_write_output_elf(kelf, kelf->elf, arguments.args[1]);
kpatch_write_output_elf(kelf, kelf->elf, arguments.args[1], 0664);
kpatch_elf_teardown(kelf);
kpatch_elf_free(kelf);

6
kpatch-build/kpatch-elf.c
View File

@ -759,7 +759,8 @@ void kpatch_rebuild_rela_section_data(struct section *sec)
ERROR("size mismatch in rebuilt rela section");
}
void kpatch_write_output_elf(struct kpatch_elf *kelf, Elf *elf, char *outfile)
void kpatch_write_output_elf(struct kpatch_elf *kelf, Elf *elf, char *outfile,
mode_t mode)
{
int fd;
struct section *sec;
@ -770,8 +771,7 @@ void kpatch_write_output_elf(struct kpatch_elf *kelf, Elf *elf, char *outfile)
Elf_Data *data;
GElf_Shdr sh;
/* TODO make this argv */
fd = creat(outfile, 0777);
fd = creat(outfile, mode);
if (fd == -1)
ERROR("creat");

3
kpatch-build/kpatch-elf.h
View File

@ -164,7 +164,8 @@ struct section *create_section_pair(struct kpatch_elf *kelf, char *name,
void kpatch_remove_and_free_section(struct kpatch_elf *kelf, char *secname);
void kpatch_reindex_elements(struct kpatch_elf *kelf);
void kpatch_rebuild_rela_section_data(struct section *sec);
void kpatch_write_output_elf(struct kpatch_elf *kelf, Elf *elf, char *outfile);
void kpatch_write_output_elf(struct kpatch_elf *kelf, Elf *elf, char *outfile,
mode_t mode);
void kpatch_elf_teardown(struct kpatch_elf *kelf);
void kpatch_elf_free(struct kpatch_elf *kelf);
#endif /* _KPATCH_ELF_H_ */