RepoMirrors/kpatch
1
0
Fork 0
mirror of https://github.com/dynup/kpatch synced 2025-04-23 23:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request from jstancek/safety_check_stacktrace

Browse Source 
kmod/core: be more verbose when activness safety check fails
This commit is contained in:
Seth Jennings 2014-06-27 09:01:31 -05:00
commit b3665a03d3
1 changed files with 22 additions and 0 deletions

22
kmod/core/core.c
View File

@ -247,6 +247,25 @@ static const struct stacktrace_ops kpatch_backtrace_ops = {
.walk_stack = print_context_stack_bp, .walk_stack = print_context_stack_bp,
}; };
static int kpatch_print_trace_stack(void *data, char *name)
{
pr_cont(" <%s> ", name);
return 0;
}
static void kpatch_print_trace_address(void *data, unsigned long addr,
int reliable)
{
if (reliable)
pr_info("[<%p>] %pB\n", (void *)addr, (void *)addr);
}
static const struct stacktrace_ops kpatch_print_trace_ops = {
.stack = kpatch_print_trace_stack,
.address = kpatch_print_trace_address,
.walk_stack = print_context_stack,
};
/* /*
* Verify activeness safety, i.e. that none of the to-be-patched functions are * Verify activeness safety, i.e. that none of the to-be-patched functions are
* on the stack of any task. * on the stack of any task.
@ -268,6 +287,9 @@ static int kpatch_verify_activeness_safety(struct kpatch_module *kpmod)
dump_trace(t, NULL, NULL, 0, &kpatch_backtrace_ops, &args); dump_trace(t, NULL, NULL, 0, &kpatch_backtrace_ops, &args);
if (args.ret) { if (args.ret) {
ret = args.ret; ret = args.ret;
pr_info("PID: %d Comm: %.20s\n", t->pid, t->comm);
dump_trace(t, NULL, (unsigned long *)t->thread.sp,
0, &kpatch_print_trace_ops, NULL);
goto out; goto out;
} }
} while_each_thread(g, t); } while_each_thread(g, t);