RepoMirrors
/
kpatch
mirror of https://github.com/dynup/kpatch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kmod/core: remove comments about preemption 

Preemption shouldn't cause a problem with determining activeness safety.
Even if a thread is preempted, it'll be on the backtrace.

We may need to disable preemption when reading the kpatch_funcs array,
but I'm removing that comment for now because the kpatch_funcs array
will soon be replaced by a much better data structure, and we'll deal
with proper synchronization then.
This commit is contained in:
Josh Poimboeuf 2014-03-13 14:04:50 -05:00
parent 57f45c89e6
commit aa5346d13b
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kmod/core/core.c
View File

@ -124,9 +124,6 @@ static int kpatch_verify_activeness_safety(struct kpatch_func *funcs)
}
} while_each_thread(g, t);
/* TODO: for preemptible support we would need to ensure that functions
* on top of the stack are actually seen on the stack.
*/
out:
return ret;
}
@ -166,13 +163,6 @@ void kpatch_ftrace_handler(unsigned long ip, unsigned long parent_ip,
int i;
struct kpatch_func *func = NULL;
/*
* TODO: if preemption is possible then we'll need to think about how
* to ensure atomic access to the array and how to ensure activeness
* safety here. if preemption is enabled then we need to make sure the
* IP isn't inside kpatch_trampoline for any task.
*/
for (i = 0; i < KPATCH_MAX_FUNCS &&
kpatch_funcs[i].old_func_addr; i++) {
if (kpatch_funcs[i].old_func_addr == ip) {