RepoMirrors/kpatch
1
0
Fork 0
mirror of https://github.com/dynup/kpatch synced 2025-01-03 03:02:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

kpatch: deprecate the replace command

Browse Source 
"kpatch replace" is complex, buggy, and probably unnecessary.  And
upstream livepatch has nothing like it.

Remove it from the kpatch utility, but leave the infrastructure in place
in the patch module and the core module for now.

Fixes: #456
This commit is contained in:
Josh Poimboeuf 2015-11-16 09:38:38 -06:00
parent eb54876936
commit 8e8de4718d
3 changed files with 4 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@ -535,10 +535,10 @@ and restore the function to its original state.
**Q. Can you apply multiple patches?**
Yes, but to prevent any unexpected interactions between multiple patch modules,
it's recommended that you only have a single patch loaded at any given time.
This can be achieved by combining the new patch with the previous patch using
`combinediff` before running `kpatch-build`. You can then the `kpatch replace`
command to atomically replace the old patch module with the new cumulative one.
it's recommended that patch upgrades are cumulative, so that each patch is a
superset of the previous patch. This can be achieved by combining the new
patch with the previous patch using `combinediff` before running
`kpatch-build`.
**Q. Why did kpatch-build detect a changed function that wasn't touched by the
source patch?**

17
kpatch/kpatch
View File

@ -42,7 +42,6 @@ usage () {
echo >&2
usage_cmd "load --all" "load all installed patch modules into the running kernel"
usage_cmd "load <module>" "load patch module into the running kernel"
usage_cmd "replace <module>" "load patch module into the running kernel, replacing all other modules"
usage_cmd "unload --all" "unload all patch modules from the running kernel"
usage_cmd "unload <module>" "unload patch module from the running kernel"
echo >&2
@ -183,14 +182,6 @@ unload_module () {
rmmod $PATCH 2> /dev/null || return 0
}
unload_disabled_modules() {
for module in /sys/kernel/kpatch/patches/*; do
if [[ $(cat $module/enabled) -eq 0 ]]; then
unload_module $(basename $module) || die "failed to unload $module"
fi
done
}
get_module_version() {
MODVER=$(modinfo -F vermagic "$1") || return 1
MODVER=${MODVER/ */}
@ -216,14 +207,6 @@ case "$1" in
esac
;;
"replace")
[[ "$#" -ne 2 ]] && usage
PATCH="$2"
find_module "$PATCH" || die "can't find $PATCH"
load_module "$MODULE" replace=1 || die "failed to load module $PATCH"
unload_disabled_modules || die "failed to unload old modules"
;;
"unload")
[[ "$#" -ne 2 ]] && usage
case "$2" in

3
man/kpatch.1
View File

@ -23,9 +23,6 @@ load --all
load <module>
load patch module into the running kernel
replace <module>
load patch module into the running kernel, replacing all other modules
unload --all
unload all patch modules from the running kernel