RepoMirrors/kpatch
1
0
Fork 0
mirror of https://github.com/dynup/kpatch synced 2025-01-02 10:42:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix memleak in the create-klp-module.c

Browse Source 
reason: The strdup() function returns a pointer to a new string
	which is a duplicate of the string s.  Memory for the
	new string is obtained with malloc, and can be freed
	with free.

	here, fix memleak by removing the strdup.

Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
This commit is contained in:
chenzefeng 2019-04-24 10:04:06 +08:00
parent bc7f34b8c5
commit 7513db3c63
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
kpatch-build/create-klp-module.c
View File

@ -57,9 +57,7 @@ static struct symbol *find_or_add_ksym_to_symbols(struct kpatch_elf *kelf,
if (!rela)
ERROR("name of ksym not found?");
name = strdup(strings + rela->addend);
if (!name)
ERROR("strdup");
name = strings + rela->addend;
/* Get objname of ksym */
rela = find_rela_by_offset(ksymsec->rela,
@ -67,9 +65,7 @@ static struct symbol *find_or_add_ksym_to_symbols(struct kpatch_elf *kelf,
if (!rela)
ERROR("objname of ksym not found?");
objname = strdup(strings + rela->addend);
if (!objname)
ERROR("strdup");
objname = strings + rela->addend;
snprintf(pos, 32, "%lu", ksym->pos);
/* .klp.sym.objname.name,pos */
@ -202,9 +198,7 @@ static void create_klp_relasecs_and_syms(struct kpatch_elf *kelf, struct section
if (!rela)
ERROR("find_rela_by_offset");
objname = strdup(strings + rela->addend);
if (!objname)
ERROR("strdup");
objname = strings + rela->addend;
/* Get the .kpatch.symbol entry for the rela src */
rela = find_rela_by_offset(krelasec->rela,
@ -282,9 +276,7 @@ static void create_klp_arch_sections(struct kpatch_elf *kelf, char *strings)
if (!rela)
ERROR("find_rela_by_offset");
objname = strdup(strings + rela->addend);
if (!objname)
ERROR("strdup");
objname = strings + rela->addend;
/* Example: .klp.arch.vmlinux..parainstructions */
snprintf(buf, 256, "%s%s.%s", KLP_ARCH_PREFIX, objname, base->name);