From 501a63ad6d0a14362d6674055a834635740197bd Mon Sep 17 00:00:00 2001 From: Joe Lawrence Date: Tue, 13 Dec 2016 16:53:52 -0500 Subject: [PATCH] smatch,sparse: trivial code cleanups Fixes smatch warning: kmod/core/core.c:64:1: warning: symbol 'kpmod_list' was not declared. Should it be static? Fixes sparse warnings: kmod/core/core.c:680 kpatch_write_relocations() warn: inconsistent indenting kmod/core/core.c:750 kpatch_write_relocations() warn: inconsistent indenting --- kmod/core/core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kmod/core/core.c b/kmod/core/core.c index adad44d..cbfffe8 100644 --- a/kmod/core/core.c +++ b/kmod/core/core.c @@ -66,7 +66,7 @@ static DEFINE_HASHTABLE(kpatch_func_hash, KPATCH_HASH_BITS); static DEFINE_SEMAPHORE(kpatch_mutex); -LIST_HEAD(kpmod_list); +static LIST_HEAD(kpmod_list); static int kpatch_num_patched; @@ -641,11 +641,11 @@ static int kpatch_write_relocations(struct kpatch_module *kpmod, ( LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 0) && \ UTS_UBUNTU_RELEASE_ABI >= 7 ) \ ) - unsigned long core = (unsigned long)kpmod->mod->core_layout.base; - unsigned long core_size = kpmod->mod->core_layout.size; + unsigned long core = (unsigned long)kpmod->mod->core_layout.base; + unsigned long core_size = kpmod->mod->core_layout.size; #else - unsigned long core = (unsigned long)kpmod->mod->module_core; - unsigned long core_size = kpmod->mod->core_size; + unsigned long core = (unsigned long)kpmod->mod->module_core; + unsigned long core_size = kpmod->mod->core_size; #endif list_for_each_entry(dynrela, &object->dynrelas, list) {