From 8ab170d402927212ba4c815ac7ea473fe508a4e1 Mon Sep 17 00:00:00 2001
From: Simon Ruderich <simon@ruderich.org>
Date: Tue, 22 Aug 2017 03:18:41 +0200
Subject: [PATCH] kpatch-build: use implicit make rules

This removes duplicate code which is already handled by make internally
and also respects CPPFLAGS.

LDFLAGS are general linker flags, LDLIBS should be used for the
libraries itself. Therefore switch to LDLIBS which is put after the
object files in the command line (which is not true for LDFLAGS).
---
 kpatch-build/Makefile | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/kpatch-build/Makefile b/kpatch-build/Makefile
index 6a1248a..043ca28 100644
--- a/kpatch-build/Makefile
+++ b/kpatch-build/Makefile
@@ -1,7 +1,7 @@
 include ../Makefile.inc
 
-CFLAGS  += -I../kmod/patch -Iinsn -Wall -g -Werror
-LDFLAGS += -lelf
+CFLAGS += -MMD -MP -I../kmod/patch -Iinsn -Wall -g -Werror
+LDLIBS = -lelf
 
 TARGETS = create-diff-object create-klp-module create-kpatch-module
 SOURCES = create-diff-object.c kpatch-elf.c \
@@ -19,17 +19,11 @@ all: $(TARGETS)
 
 -include $(SOURCES:.c=.d)
 
-%.o : %.c
-	$(CC) -MMD -MP $(CFLAGS) -c -o $@ $<
-
 create-diff-object: create-diff-object.o kpatch-elf.o \
 					lookup.o $(INSN)
 create-klp-module: create-klp-module.o kpatch-elf.o
 create-kpatch-module: create-kpatch-module.o kpatch-elf.o
 
-$(TARGETS):
-	$(CC) $(CFLAGS) $^ -o $@ $(LDFLAGS)
-
 install: all
 	$(INSTALL) -d $(LIBEXECDIR)
 	$(INSTALL) $(TARGETS) kpatch-gcc $(LIBEXECDIR)