RepoMirrors/kpatch
1
0
Fork 0
mirror of https://github.com/dynup/kpatch synced 2025-01-29 16:22:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix symbol migration

Browse Source 
kpatch_migrate_included_symbols() is called from
kpatch_reorder_symbols() now, not kpatch_migrate_included_elements().
The difference is the kpatch_reorder_symbols() is operating on the
output kpatch_elf structure, and thus all symbols are by definition
included.

Remove the check and rename the function since it is redundant.

Signed-off-by: Seth Jennings <sjenning@redhat.com>
This commit is contained in:
Seth Jennings 2014-05-23 15:46:41 -05:00
parent 9261bcc642
commit 46a7a0b7b8
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
kpatch-build/create-diff-object.c
View File

@ -819,16 +819,13 @@ int kpatch_include_changed_functions(struct kpatch_elf *kelf)
return changed_nr;
}
void kpatch_migrate_included_symbols(struct list_head *src,
void kpatch_migrate_symbols(struct list_head *src,
struct list_head *dst,
int (*select)(struct symbol *))
{
struct symbol *sym, *safe;
list_for_each_entry_safe(sym, safe, src, list) {
if (!sym->include)
continue;
if (select && !select(sym))
continue;
@ -901,15 +898,15 @@ void kpatch_reorder_symbols(struct kpatch_elf *kelf)
LIST_HEAD(symbols);
/* migrate NULL sym */
kpatch_migrate_included_symbols(&kelf->symbols, &symbols, is_null_sym);
kpatch_migrate_symbols(&kelf->symbols, &symbols, is_null_sym);
/* migrate LOCAL FILE sym */
kpatch_migrate_included_symbols(&kelf->symbols, &symbols, is_file_sym);
kpatch_migrate_symbols(&kelf->symbols, &symbols, is_file_sym);
/* migrate LOCAL FUNC syms */
kpatch_migrate_included_symbols(&kelf->symbols, &symbols, is_local_func_sym);
kpatch_migrate_symbols(&kelf->symbols, &symbols, is_local_func_sym);
/* migrate all other LOCAL syms */
kpatch_migrate_included_symbols(&kelf->symbols, &symbols, is_local_sym);
kpatch_migrate_symbols(&kelf->symbols, &symbols, is_local_sym);
/* migrate all other (GLOBAL) syms */
kpatch_migrate_included_symbols(&kelf->symbols, &symbols, NULL);
kpatch_migrate_symbols(&kelf->symbols, &symbols, NULL);
list_replace(&symbols, &kelf->symbols);
}