From 2ae4f5af4a360103bd9013b42b9b1f1c580bafc8 Mon Sep 17 00:00:00 2001 From: Joe Lawrence Date: Thu, 30 Mar 2017 10:44:53 -0400 Subject: [PATCH] doc: function prototype change workaround suggestion --- doc/patch-author-guide.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/patch-author-guide.md b/doc/patch-author-guide.md index ef3a143..26e3db1 100644 --- a/doc/patch-author-guide.md +++ b/doc/patch-author-guide.md @@ -342,7 +342,10 @@ When changing header files, be extra careful. If data is being changed, you probably need to modify the patch. See "Data struct changes" above. If a function prototype is being changed, make sure it's not an exported -function. Otherwise it could break out-of-tree modules. +function. Otherwise it could break out-of-tree modules. One way to +workaround this is to define an entirely new copy of the function (with +updated code) and patch in-tree callers to invoke it rather than the +deprecated version. Many header file changes result in a complete rebuild of the kernel tree, which makes kpatch-build have to compare every .o file in the kernel. It slows the