From 22e2c1a95c1714ed7a26d822d82f9d863ef24dbf Mon Sep 17 00:00:00 2001 From: Julien Thierry Date: Wed, 3 Jun 2020 10:10:19 +0100 Subject: [PATCH] test: Ignore remaining quoting warnings Fixing the remaining warnings suggesting to quote the output subshell invocation would hinder readability. Also the results of dirname and "type -p" used in the subshell should return spaceless strings in kpatch usecases. Ignore the warnings for now. Signed-off-by: Julien Thierry --- test/difftree.sh | 2 ++ test/integration/kpatch-test | 1 + 2 files changed, 3 insertions(+) diff --git a/test/difftree.sh b/test/difftree.sh index f797bf0..9a0ebf4 100755 --- a/test/difftree.sh +++ b/test/difftree.sh @@ -14,6 +14,7 @@ #set -x OBJDIR="$HOME/.kpatch/obj" +# shellcheck disable=SC2046 SCRIPTDIR=$(readlink -f $(dirname $(type -p "$0"))) TEMPDIR=$(mktemp -d) RESULTSDIR="$TEMPDIR/results" @@ -52,6 +53,7 @@ do # expect RETCODE to be 3 indicating no change [[ $RETCODE -eq 3 ]] && continue # otherwise record error + # shellcheck disable=SC2046 mkdir -p "$RESULTSDIR"/$(dirname "$i") || exit 1 cp "$i" "$RESULTSDIR/$i" || exit 1 case $RETCODE in diff --git a/test/integration/kpatch-test b/test/integration/kpatch-test index cf9e273..ec112dc 100755 --- a/test/integration/kpatch-test +++ b/test/integration/kpatch-test @@ -40,6 +40,7 @@ shopt -s nullglob +# shellcheck disable=SC2046 SCRIPTDIR=$(readlink -f $(dirname $(type -p "$0"))) ROOTDIR=$(readlink -f "$SCRIPTDIR/../..") # TODO: option to use system-installed binaries instead