RepoMirrors/kpatch
1
0
Fork 0
mirror of https://github.com/dynup/kpatch synced 2024-12-22 21:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

kmod/core: apply dynrela addend for R_X86_64_64

Browse Source 
User stettberger noticed that the kpatch support module does not
apply the addend for R_X86_64_64 in kpatch_write_relocations().

The AMD64 ABI draft doc [1], Table 4.10: Relocation Types lists that
relocation type as:

  Name         Value  Field   Calculation
  R_X86_64_64  1      word64  S + A

where:

  S : Represents the value of the symbol whose index resides in the
      relocation entry.

  A : Represents the addend used to compute the value of the relocatable
      field.

[1] http://refspecs.linuxfoundation.org/elf/x86_64-abi-0.99.pdf

Fixes: #1093
Reported-by: Christian Dietrich <stettberger@dokucode.de>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
This commit is contained in:
Joe Lawrence 2020-05-01 08:52:23 -04:00
parent 8e8707ed72
commit 15067fcd64
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kmod/core/core.c
View File

@ -742,7 +742,7 @@ static int kpatch_write_relocations(struct kpatch_module *kpmod,
break;
case R_X86_64_64:
loc = dynrela->dest;
val = dynrela->src;
val = dynrela->src + dynrela->addend;
size = 8;
break;
default: