RepoMirrors
/
kpatch
mirror of https://github.com/dynup/kpatch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
kpatch/test/unit/Makefile.include

74 lines
2.4 KiB
Makefile
Raw Normal View History

Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
EXT_ORIG ?= ORIG.o
EXT_PATCHED ?= PATCHED.o
EXT_FAIL ?= PATCHED.FAIL.o
EXT_TEST ?= test
EXT_OUTPUT ?= OUTPUT.o
EXT_TEST_OUTPUT ?= test.out
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
EXT_SYMTAB ?= symtab
EXT_SYMVERS ?= symvers
test/unit: add support for .env files Add support for optional <test-name>.env files that contain additional environment variables. This can also be used to override per-arch env vars we have because last value assigned will be used. Signed-off-by: Artem Savkov <asavkov@redhat.com>
2019-02-08 14:09:18 +00:00
EXT_ENV ?= env
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
TNAME = $(@:.$(EXT_OUTPUT)=)
ifndef VERBOSE
unit: don't suppress stderr in non-fail tests Don't suppress stderr in the non-fail unit tests so that create-diff-object error messages will be printed. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-17 22:45:41 +00:00
MUTE_PASS := >/dev/null
MUTE_FAIL := >/dev/null 2>&1
test/unit: further silence non-verbose mode Just show a summary of each test command in non-verbose mode. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-20 13:13:55 +00:00
.SILENT: $(TARGETS) $(TEST_TARGETS)
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
endif
Add kpatch-unit-objs submodule Add a submodule containing object files for unittests. Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-04-26 13:24:40 +00:00
SRC_PATH ?= $(realpath ../../../../)
test/unit: add a library for common functions I placed the library in the top-level test directory, as the same assertions could also be used by the integration tests once we rework them a bit. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-20 12:25:10 +00:00
CDO ?= $(SRC_PATH)/kpatch-build/create-diff-object
TEST_LIBRARY ?= $(SRC_PATH)/test/test-functions.sh
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
test/unit: add a library for common functions I placed the library in the top-level test directory, as the same assertions could also be used by the integration tests once we rework them a bit. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-20 12:25:10 +00:00
TEST_ENV = KPATCH_TEST_LIBRARY=$(TEST_LIBRARY)
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
TARGETS = $(patsubst %.$(EXT_ORIG),%.$(EXT_OUTPUT),$(wildcard *.$(EXT_ORIG)))
TEST_TARGETS = $(patsubst %.$(EXT_TEST),%.$(EXT_TEST_OUTPUT),$(wildcard *.$(EXT_TEST)))
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
SYMVERS_FILE = $(if $(wildcard $(TNAME).$(EXT_SYMVERS)),$(TNAME).$(EXT_SYMVERS),/dev/null)
uinttests: add strip check Check that files are stripped of debuginfo as it is useless for unittesting at this moment. Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-04-13 08:36:57 +00:00
define check_stripped =
$(if $(shell readelf --debug-dump $(1)),
$(error $(1) is not properly stripped, use 'strip --strip-debug --keep-file-symbols $(1)' to fix this),
)
endef
unittests: check that obj files are fetched Check that tested .o is not an lfs meta-file before testing. Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-04-13 08:55:58 +00:00
define check_all =
test/unit: relax stripped object requirement Some unit tests may need debug symbols to reproduce problems (see issue #928 for example), so skip the unit-test Makefile.include check_stripped call for objects that include "NOSTRIP" in their filename. Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
2019-02-19 18:11:42 +00:00
$(if $(findstring NOSTRIP,$(1)), , $(call check_stripped,$(1)))
unittests: check that obj files are fetched Check that tested .o is not an lfs meta-file before testing. Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-04-13 08:55:58 +00:00
endef
tests/unit: fix inconsistent FAIL test failures Use make's .DELETE_ON_ERROR special target to make sure we don't have any .OUTPUT.o leftovers for failed tests. Fixes: #999 Signed-off-by: Artem Savkov <asavkov@redhat.com>
2019-07-23 08:57:43 +00:00
.DELETE_ON_ERROR: %.$(EXT_OUTPUT)
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
all: $(TARGETS) $(TEST_TARGETS)
clean:
test/unit: broaden the 'clean' target Broaden the impact of the 'clean' target so that output objects will still get cleaned when when old tests get removed or renamed. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-19 21:47:06 +00:00
rm -f *.$(EXT_TEST_OUTPUT) *.$(EXT_OUTPUT)
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
%.$(EXT_SYMTAB):
test/unit: Fix symtab generation for ppc64le The ppc64le unit tests are failing because the lookup code is getting confused by the "[<localentry>: 8]" string in the readelf symbol table output. Remove the string so the lookup code can parse it correctly. kpatch-build already uses the same sed, so they should match. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2019-07-22 19:37:59 +00:00
readelf -s --wide $(patsubst %.$(EXT_SYMTAB),%.$(EXT_ORIG),$(@)) | \
sed -r 's/\s+\[<localentry>: 8\]//' >$@
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
test/unit: add a library for common functions I placed the library in the top-level test directory, as the same assertions could also be used by the integration tests once we rework them a bit. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-20 12:25:10 +00:00
%.$(EXT_TEST_OUTPUT): %.$(EXT_OUTPUT) %.$(EXT_TEST) $(TEST_LIBRARY)
test/unit: further silence non-verbose mode Just show a summary of each test command in non-verbose mode. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-20 13:13:55 +00:00
@echo "TEST $(@:.$(EXT_TEST_OUTPUT)=)"
test/unit: add a library for common functions I placed the library in the top-level test directory, as the same assertions could also be used by the integration tests once we rework them a bit. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-20 12:25:10 +00:00
$(TEST_ENV) bash $(@:.$(EXT_TEST_OUTPUT)=.$(EXT_TEST)) $<
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
# Don't rely on script creating this
@touch $@
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
%.$(EXT_OUTPUT): %.$(EXT_ORIG) %.$(EXT_PATCHED) %.$(EXT_SYMTAB) $(CDO)
test/unit: further silence non-verbose mode Just show a summary of each test command in non-verbose mode. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-20 13:13:55 +00:00
@echo "BUILD $(TNAME)"
unittests: check that obj files are fetched Check that tested .o is not an lfs meta-file before testing. Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-04-13 08:55:58 +00:00
$(call check_all,$(TNAME).$(EXT_ORIG))
$(call check_all,$(TNAME).$(EXT_PATCHED))
test/unit: Fix env override for Make 3.x Make 3.8 doesn't support the "file" function, which is used by the unit test Makefile to output the contents of a custom env file, if one exists. Use shell instead. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2019-07-17 02:58:41 +00:00
$(CDO_ENV) $(shell cat $(TNAME).$(EXT_ENV) 2>/dev/null) $(CDO) $(TNAME).$(EXT_ORIG) $(TNAME).$(EXT_PATCHED) \
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
vmlinux $(TNAME).$(EXT_SYMTAB) $(SYMVERS_FILE) \
test_$(TNAME) $@ $(MUTE_PASS)
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
%.$(EXT_OUTPUT): %.$(EXT_ORIG) %.$(EXT_FAIL) %.$(EXT_SYMTAB) $(CDO)
test/unit: further silence non-verbose mode Just show a summary of each test command in non-verbose mode. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2018-04-20 13:13:55 +00:00
@echo "BUILD $(TNAME)-FAIL"
unittests: check that obj files are fetched Check that tested .o is not an lfs meta-file before testing. Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-04-13 08:55:58 +00:00
$(call check_all,$(TNAME).$(EXT_ORIG))
$(call check_all,$(TNAME).$(EXT_FAIL))
test/unit: Fix env override for Make 3.x Make 3.8 doesn't support the "file" function, which is used by the unit test Makefile to output the contents of a custom env file, if one exists. Use shell instead. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
2019-07-17 02:58:41 +00:00
! $(CDO_ENV) $(shell cat $(TNAME).$(EXT_ENV) 2>/dev/null) $(CDO) $(TNAME).$(EXT_ORIG) $(TNAME).$(EXT_FAIL) \
kpatch-build: use symbol table instead of kobject create-diff-object doesn't really need the full kernel object file as input. All it requires is a symbol table. Switch to using "eu-readelf -s"'s output instead of object files. This will enable us to cover more cases in unit tests. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-05-11 09:51:00 +00:00
vmlinux $(TNAME).$(EXT_SYMTAB) $(SYMVERS_FILE) \
test_$(TNAME) $@ $(MUTE_FAIL)
Add create-diff-object unittest framework Add a simple unittest framework for create-diff-object implemented in GNU Make. It will automatically scan the kpatch-unit-objs/$(uname -m) directory for specifically named files running one of 3 tests: - creating diff object with expected success - creating diff object with expected failure - creating diff object and running a shell script on it with expected success Signed-off-by: Artem Savkov <asavkov@redhat.com>
2018-03-20 19:39:36 +00:00
# Expecting to fail, thus create output file manually so we won't rerun the
# test without clean
@touch $@