mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2025-01-19 12:10:46 +00:00
haproxy public development tree
fc51f0f588
There's a very hard-to-trigger bug in the FD list code where the fd_add_to_fd_list() function assumes that if the FD it's trying to add is already locked, it's in the process of being added. Unfortunately, it can also be in the process of being removed. It is very hard to trigger because it requires that one thread is removing the FD while another one is adding it. First very few FDs run on multiple threads (listeners and DNS), and second, it does not make sense to add and remove the FD at the same time. In practice the DNS code built on the older callback-only model does perform bursts of fd_want_send() for all resolvers at once when it wants to send a new query (dns_send_query()). And this is more likely to happen when here are lots of resolutions in parallel and many resolvers, because the dns_response_recv() callback can also trigger a series of queries on all resolvers for each invalid response it receives. This means that it really is perfectly possible to both stop and start in parallel during short periods of time there. This issue was not reported before 2.1, but 2.1 had the FD cache, built on the exact same code base. It's very possible that the issue caused exactly the opposite situation, where an event was occasionally lost, causing a DNS retry that worked, and nobody noticing the problem in the end. In 2.1 the lost entries are the updates asking for not polling for writes anymore, and the effect is that the poller contiuously reports writability on the socket when the issue happens. This patch fixes bug #416 and must be backported as far as 1.8, and absolutely requires that previous commit "MINOR: fd/threads: make _GET_NEXT()/_GET_PREV() use the volatile attribute" is backported as well otherwise it will make the issue worse. Special thanks to Julien Pivotto for setting up a reliable reproducer for this difficult issue. |
||
|---|---|---|
| .github/ISSUE_TEMPLATE | ||
| contrib | ||
| doc | ||
| ebtree | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitignore | ||
| .travis.yml | ||
| BRANCHES | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README | ||
| ROADMAP | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)