mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2025-01-21 13:02:55 +00:00
e1465c1e46
Some regtests involve multiple requests from multiple clients, which can be dispatched as multiple requests to a server. It turns out that the idle connection sharing works so well that very quickly few connections are used, and regularly some of the remaining idle server connections time out at the moment they were going to be reused, causing those random "HTTP header incomplete" traces in the logs that make them fail often. In the end this is only an artefact of the test environment. And indeed, some tests like normalize-uri which perform a lot of reuse fail very often, about 20-30% of the times in the CI, and 100% of the time in local when running 1000 tests in a row. Others like ubase64, sample_fetches or vary_* fail less often but still a lot in tests. This patch addresses this by adding "tune.idle-pool.shared off" to all tests which have at least twice as many requests as clients. It proves very effective as no single error happens on normalize-uri anymore after 10000 tests. Also 100 full runs of all tests yield no error anymore. One test is tricky, http_abortonclose, it used to fail ~10 times per 1000 runs and with this workaround still fails once every 1000 runs. But the test is complex and there's a warning in it mentioning a possible issue when run in parallel due to a port reuse.
129 lines
3.1 KiB
Plaintext
129 lines
3.1 KiB
Plaintext
varnishtest "A test to be sure payload is skipped for bodyless responses"
|
|
feature ignore_unknown_macro
|
|
|
|
#REQUIRE_VERSION=2.4
|
|
|
|
server s1 {
|
|
rxreq
|
|
txresp \
|
|
-status 200 \
|
|
-body "skipped data"
|
|
|
|
rxreq
|
|
txresp \
|
|
-status 200 \
|
|
-bodylen 20000
|
|
|
|
rxreq
|
|
txresp \
|
|
-status 200 \
|
|
-nolen -hdr "Transfer-Encoding: chunked"
|
|
chunkedlen 15
|
|
chunkedlen 1024
|
|
chunkedlen 4048
|
|
chunkedlen 0
|
|
|
|
rxreq
|
|
txresp \
|
|
-status 200 \
|
|
-body "last response"
|
|
} -repeat 2 -start
|
|
|
|
haproxy h1 -conf {
|
|
global
|
|
# WT: limit false-positives causing "HTTP header incomplete" due to
|
|
# idle server connections being randomly used and randomly expiring
|
|
# under us.
|
|
tune.idle-pool.shared off
|
|
|
|
defaults
|
|
mode http
|
|
${no-htx} option http-use-htx
|
|
timeout connect 1s
|
|
timeout client 1s
|
|
timeout server 1s
|
|
|
|
listen fe1
|
|
bind "fd@${fe1}"
|
|
# Rewrite the method to be sure to get the response payload
|
|
# on the server side
|
|
http-request set-method GET
|
|
server s1 ${s1_addr}:${s1_port}
|
|
|
|
listen int
|
|
bind "fd@${int}" proto h2
|
|
# Rewrite the method to be sure to get the response payload
|
|
# on the server side
|
|
http-request set-method GET
|
|
server s1 ${s1_addr}:${s1_port}
|
|
#server s1 ${h1_fe1_addr}:${h1_fe1_port}
|
|
|
|
listen fe2
|
|
bind "fd@${fe2}"
|
|
server s1 ${h1_int_addr}:${h1_int_port} proto h2
|
|
} -start
|
|
|
|
client c1 -connect ${h1_fe1_sock} {
|
|
txreq \
|
|
-req "HEAD" \
|
|
-url "/req1"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.body == ""
|
|
|
|
txreq \
|
|
-req "HEAD" \
|
|
-url "/req2"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.body == ""
|
|
|
|
txreq \
|
|
-req "HEAD" \
|
|
-url "/req3"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.body == ""
|
|
|
|
# The last one have a body and validate the connection was not closed
|
|
# unexpectedly and no payload was received for previous requests
|
|
txreq \
|
|
-req "GET" \
|
|
-url "/req4"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.body == "last response"
|
|
} -run
|
|
|
|
client c2 -connect ${h1_fe2_sock} {
|
|
txreq \
|
|
-req "HEAD" \
|
|
-url "/req1"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.body == ""
|
|
|
|
txreq \
|
|
-req "HEAD" \
|
|
-url "/req2"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.body == ""
|
|
|
|
txreq \
|
|
-req "HEAD" \
|
|
-url "/req3"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.body == ""
|
|
|
|
# The last one have a body and validate the connection was not closed
|
|
# unexpectedly and no payload was received for previous requests
|
|
txreq \
|
|
-req "GET" \
|
|
-url "/req4"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.body == "last response"
|
|
} -run
|