Krzysztof Piotr Oledzki e6bbd74690 [MEDIUM] Handle long lines properly ... Currently, there is a hidden line length limit in the haproxy, set to 256-1 chars. With large acls (for example many hdr(host) matches) it may be not enough and which is even worse, error message may be totally confusing as everything above this limit is treated as a next line: echo -ne "frontend aqq 1.2.3.4:80\nmode http\nacl e hdr(host) -i X X X X X X X www.xx.example.com stats\n"| sed s/X/www.some-host-name.example.com/g > ha.cfg && haproxy -c -f ./ha.cfg [WARNING] 300/163906 (11342) : parsing [./ha.cfg:4] : 'stats' ignored because frontend 'aqq' has no backend capability. Recently I hit simmilar problem and it took me a while to find why requests for "stats" are not handled properly. This patch: - makes the limit configurable (LINESIZE) - increases default line length limit from 256 to 2048 - increases MAX_LINE_ARGS from 40 to 64 - fixes hidden assignment in fgets() - moves arg/end/args/line inside the loop, making code auditing easier - adds a check that shows error if the limit is reached - changes "*line++ = 0;" to "*line++ = '\0';" (cosmetics) With this patch, when LINESIZE is defined to 256, above example produces: [ALERT] 300/164724 (27364) : parsing [/tmp/ha.cfg:3]: line too long, limit: 255. [ALERT] 300/164724 (27364) : Error reading configuration file : /tmp/ha.cfg		2007-11-01 23:00:51 +01:00
..
common	[MEDIUM] Handle long lines properly	2007-11-01 23:00:51 +01:00
import	[MAJOR] migrated task, tree64 and session to pool2	2007-05-13 19:43:47 +02:00
proto	[MEDIUM] stats: report server and backend cumulated downtime	2007-10-22 21:36:23 +02:00
types	[MINOR] add socket address length to the protocols	2007-10-28 12:09:45 +01:00