haproxy/include
Willy Tarreau d66345d6b0 BUG/MINOR: threads: fix multiple use of argument inside HA_ATOMIC_CAS()
When threads are disabled, HA_ATOMIC_CAS() becomes a simple compound
expression. However this expression presents a problem, which is that
its arguments are evaluated multiple times, once for the comparison
and once again for the assignement. This presents a risk of performing
some side-effect operations twice in the non-threaded case (e.g. in
case of auto-increment or function return).

The macro was rewritten using local copies for arguments like the
other macros do.

Fortunately a complete inspection of the code indicates that this case
currently never happens. It was however responsible for the strict-aliasing
warning emitted when building fd.c without threads but with 64-bit CAS.

This may be backported as far as 1.8 though it will not fix any existing
bug and is more of a long-term safety measure in case a future fix would
depend on this behavior.
2020-05-05 16:05:45 +02:00
..
common BUG/MINOR: threads: fix multiple use of argument inside HA_ATOMIC_CAS() 2020-05-05 16:05:45 +02:00
import
proto MINOR: http-htx: Support different methods to look for header names 2020-05-05 11:07:00 +02:00
types MEDIUM: checks: Support matching on headers for http-check expect rules 2020-05-05 11:19:27 +02:00