mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2024-12-25 22:22:11 +00:00
501c99588e
William noticed that the real issue in the abns test was that it was failing to rebind some listeners, issues which were addressed in the previous commits (in some cases, the master would even accept traffic on the worker's socket which was not properly disabled, causing some of the strange error messages). The other issue documented in commit 2ea15a080 was the lack of reliability when the test was run in parallel. This is caused by the abns socket which uses a hard-coded address, making all tests in parallel to step onto each others' toes. Since vtest cannot provide abns sockets, we're instead concatenating the number of the listening port that vtest allocated for another frontend to the abns path, which guarantees to make them unique in the system. The test works fine in all cases now, even with 100 in parallel.
56 lines
1.7 KiB
Plaintext
56 lines
1.7 KiB
Plaintext
# commit b4dd15b
|
|
# BUG/MINOR: unix: Make sure we can transfer abns sockets on seamless reload.
|
|
#
|
|
# When checking if a socket we got from the parent is suitable for a listener,
|
|
# we just checked that the path matched sockname.tmp, however this is
|
|
# unsuitable for abns sockets, where we don't have to create a temporary
|
|
# file and rename it later.
|
|
# To detect that, check that the first character of the sun_path is 0 for
|
|
# both, and if so, that &sun_path[1] is the same too.
|
|
#
|
|
# Note: there are some tricks here. One of them is that we must not bind the
|
|
# same abns address to multiple processes that may run in parallel. Since
|
|
# vtest cannot provide abns sockets, we're instead concatenating the number
|
|
# of the listening port that vtest allocated for another frontend to the abns
|
|
# path, which guarantees to make them unique in the system.
|
|
|
|
varnishtest "Seamless reload issue with abns sockets"
|
|
feature ignore_unknown_macro
|
|
|
|
# abns@ sockets are not available on freebsd
|
|
#EXCLUDE_TARGETS=freebsd,osx,generic
|
|
#REQUIRE_VERSION=1.8
|
|
#REGTEST_TYPE=bug
|
|
|
|
haproxy h1 -W -conf {
|
|
global
|
|
stats socket "${tmpdir}/h1/stats" level admin expose-fd listeners
|
|
|
|
defaults
|
|
mode http
|
|
${no-htx} option http-use-htx
|
|
log global
|
|
option httplog
|
|
timeout connect 1s
|
|
timeout client 1s
|
|
timeout server 1s
|
|
|
|
listen testme
|
|
bind "fd@${testme}"
|
|
server test_abns_server abns@wpproc1_${h1_testme_port} send-proxy-v2
|
|
|
|
frontend test_abns
|
|
bind abns@wpproc1_${h1_testme_port} accept-proxy
|
|
http-request deny deny_status 200
|
|
} -start
|
|
|
|
shell {
|
|
kill -USR2 $(cat "${tmpdir}/h1/pid")
|
|
}
|
|
|
|
client c1 -connect ${h1_testme_sock} {
|
|
txreq -url "/"
|
|
rxresp
|
|
} -repeat 50 -run
|
|
|