mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2025-01-23 22:12:46 +00:00
9192d20f02
Since the massive pools cleanup that happened in 2.6, the pools architecture was made quite more hierarchical and many alternate code blocks could be moved to runtime flags set by -dM. One of them had not been converted by then, DEBUG_UAF. It's not much more difficult actually, since it only acts on a pair of functions indirection on the slow path (OS-level allocator) and a default setting for the cache activation. This patch adds the "uaf" setting to the options permitted in -dM so that it now becomes possible to set or unset UAF at boot time without recompiling. This is particularly convenient, because every 3 months on average, developers ask a user to recompile haproxy with DEBUG_UAF to understand a bug. Now it will not be needed anymore, instead the user will only have to disable pools and enable uaf using -dMuaf. Note that -dMuaf only disables previously enabled pools, but it remains possible to re-enable caching by specifying the cache after, like -dMuaf,cache. A few tests with this mode show that it can be an interesting combination which catches significantly less UAF but will do so with much less overhead, so it might be compatible with some high-traffic deployments. The change is very small and isolated. It could be helpful to backport this at least to 2.7 once confirmed not to cause build issues on exotic systems, and even to 2.6 a bit later as this has proven to be useful over time, and could be even more if it did not require a rebuild. If a backport is desired, the following patches are needed as well: CLEANUP: pools: move the write before free to the uaf-only function CLEANUP: pool: only include pool-os from pool.c not pool.h REORG: pool: move all the OS specific code to pool-os.h CLEANUP: pools: get rid of CONFIG_HAP_POOLS DEBUG: pool: show a few examples in -dMhelp |
||
|---|---|---|
| .. | ||
| api | ||
| acl.txt | ||
| body-parsing.txt | ||
| connect-status.txt | ||
| connection-header.txt | ||
| connection-scale.txt | ||
| entities-v2.txt | ||
| entities.txt | ||
| fd-migration.txt | ||
| hashing.txt | ||
| header-parser-speed.txt | ||
| header-tree.txt | ||
| http-cookies.txt | ||
| http-docs.txt | ||
| http-parsing.txt | ||
| list.fig | ||
| list.png | ||
| listener-states.fig | ||
| listener-states.png | ||
| lua_socket.fig | ||
| lua_socket.pdf | ||
| muxes.fig | ||
| muxes.pdf | ||
| muxes.png | ||
| muxes.svg | ||
| naming.txt | ||
| notes-layers.txt | ||
| notes-poll-connect.txt | ||
| notes-pollhup.txt | ||
| notes-polling.txt | ||
| pattern.dia | ||
| pattern.pdf | ||
| polling-states.fig | ||
| repartition-be-fe-fi.txt | ||
| sched.fig | ||
| sched.pdf | ||
| sched.png | ||
| sched.svg | ||
| ssl_cert.dia | ||
| stats-v2.txt | ||
| stream-sock-states.fig | ||
