mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2025-03-01 09:00:51 +00:00
922a806075
Kai Krueger found that previous patch was incomplete, because there is
an unconditionnal call to process_srv_queue() in session_free() which
still causes a dead server to consume pending connections from the
backend.
This call was made unconditionnal so that we don't leave unserved
connections in the server queue, for instance connections coming
in with "option persist" which can bypass the server status check.
However, the server must not touch the backend's queue if it is down.
Another fear was that some connections might remain unserved when
the server is using a dynamic maxconn if the number of connections
to the backend is too low. Right now, srv_dynamic_maxconn() ensures
this cannot happen, so the call can remain conditionnal.
The fix consists in allowing a server to process it own queue whatever
its state, but not to touch the backend's queue if it is down. Its
queue should normally be empty when the server is down because it is
redistributed when the server goes down. The only remaining cases are
precisely the persistent connections with "option persist" set, coming
in after the queue has been redispatched. Those ones must still be
processed when a connection terminates.
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| acl.h | ||
| backend.h | ||
| buffers.h | ||
| checks.h | ||
| client.h | ||
| cttproxy.h | ||
| dumpstats.h | ||
| fd.h | ||
| hdr_idx.h | ||
| httperr.h | ||
| log.h | ||
| proto_http.h | ||
| proto_tcp.h | ||
| proto_uxst.h | ||
| protocols.h | ||
| proxy.h | ||
| queue.h | ||
| server.h | ||
| session.h | ||
| stream_interface.h | ||
| stream_sock.h | ||
| task.h | ||
| template.h | ||