mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2024-12-14 15:34:35 +00:00
0184ea71a6
It is important to defined analyzers (AN_REQ_* and AN_RES_*) in the same order they are evaluated in process_stream. This order is really important because during analyzers evaluation, we run them in the order of the lower bit to the higher one. This way, when an analyzer adds/removes another one during its evaluation, we know if it is located before or after it. So, when it adds an analyzer which is located before it, we can switch to it immediately, even if it has already been called once but removed since. With the time, and introduction of new analyzers, this order was broken up. the main problems come from the filter analyzers. We used values not related with their evaluation order. Furthermore, we used same values for request and response analyzers. So, to fix the bug, filter analyzers have been splitted in 2 distinct lists to have different analyzers for the request channel than those for the response channel. And of course, we have moved them to the right place. Some other analyzers have been reordered to respect the evaluation order: * AN_REQ_HTTP_TARPIT has been moved just before AN_REQ_SRV_RULES * AN_REQ_PRST_RDP_COOKIE has been moved just before AN_REQ_STICKING_RULES * AN_RES_STORE_RULES has been moved just after AN_RES_WAIT_HTTP Note today we have 29 analyzers, all stored into a 32 bits bitfield. So we can still add 4 more analyzers before having a problem. A good way to fend off the problem for a while could be to have a different bitfield for request and response analyzers. [wt: all of this must be backported to 1.7, and part of it must be backported to 1.6 and 1.5] |
||
|---|---|---|
| .. | ||
| acl.txt | ||
| body-parsing.txt | ||
| buffer-operations.txt | ||
| buffer-ops.fig | ||
| connect-status.txt | ||
| connection-header.txt | ||
| connection-scale.txt | ||
| entities-v2.txt | ||
| entities.fig | ||
| entities.pdf | ||
| entities.svg | ||
| entities.txt | ||
| filters.txt | ||
| hashing.txt | ||
| header-parser-speed.txt | ||
| header-tree.txt | ||
| http-cookies.txt | ||
| http-docs.txt | ||
| http-parsing.txt | ||
| list.fig | ||
| lua_socket.fig | ||
| lua_socket.pdf | ||
| naming.txt | ||
| pattern.dia | ||
| pattern.pdf | ||
| polling-states.fig | ||
| repartition-be-fe-fi.txt | ||
| sequence.fig | ||
| stats-v2.txt | ||
| stream-sock-states.fig | ||
