mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2025-01-16 02:30:46 +00:00
4a78f766ff
In fact there is already flags on the SE to state a shutdown for reads or writes was performed. But for applets, this notion does not exist. Both flags are set in same time when the applet is released. But at the SC level, there are functions to perform a shutdown (formely the shutw) and an abort (formely the shutr). For applets, when a shutdown is performed on the SC, if the applet is not immediately released, nothing is acknowledge at the SE level. With old way to implement applets, this was not an real issue until recently because applets accessed to the channel/SC flags. It was thus possible to catch the shutdowns. But the "wait" command on the CLI reveals the flaw. Indeed, when this command is executed, nothing is read or sent. So, it is not possible to detect the shutdowns. As a workaround, a dedicated test on the SC flags was added at the end of the wait command I/O handler. But it is pretty ugly. With new way to implement applets, there is no longer access to the channel or SC. So we must add a way to acknowledge shutdown into the SE. This patch solves the both sides of the issue. The shutw notion is added for applets. Its only purpose is to set SE_FL_SHWN flags. This flag is tested by all applets, so, it solves the issue quite simply. Note that it is described as a bug fix but there is no real issue, just a design flaw. However, if the "wait" command is backported, this patch must be backported too. Unfortinately it will require an adaptation because there is no appctx flags on older versions. |
||
---|---|---|
.. | ||
haproxy | ||
import | ||
make |