mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2025-03-04 18:39:37 +00:00
2ea15a0804
This test is inherently racy. It regularly pops up on the CI, and I've
spent one hour chasing a bug that apparently doesn't exist, just because
I'm running it 10 times in a row and it reports from 4 to 8 failures
when built at -O2 and generally even more at -O0. The logs are very
confusing, often reporting that it failed with status 0, with nothing
else wrong. I suspect it might sometimes be the shell command that fails
if it executes faster than haproxy finishes to start up, which would
also explain the relation with the optimization level. E.g:
> Testing with haproxy version: 2.2.0
> # top TEST reg-tests/seamless-reload/abns_socket.vtc FAILED (3.006) exit=2
> # top TEST reg-tests/seamless-reload/abns_socket.vtc FAILED (3.006) exit=2
> # top TEST reg-tests/seamless-reload/abns_socket.vtc FAILED (3.009) exit=2
> # top TEST reg-tests/seamless-reload/abns_socket.vtc FAILED (3.008) exit=2
> # top TEST reg-tests/seamless-reload/abns_socket.vtc FAILED (3.007) exit=2
> # top TEST reg-tests/seamless-reload/abns_socket.vtc FAILED (3.007) exit=2
> 6 tests failed, 0 tests skipped, 4 tests passed
Some of the failures include this, suggesting that some barriers could
help:
---- h1 haproxy h1 PID file check failed:
Could not read PID file '/tmp/haregtests-2020-10-09_11-19-40.kgsDB4/vtc.30539.04dbea7f/h1/pid
Since it has been causing false positives and consumed way more
troubleshooting time than it saved, let's mark it as broken so that it
doesn't waste more time. We can bring it back when someone manages to
figure what the problem is.
50 lines
1.3 KiB
Plaintext
50 lines
1.3 KiB
Plaintext
# commit b4dd15b
|
|
# BUG/MINOR: unix: Make sure we can transfer abns sockets on seamless reload.
|
|
#
|
|
# When checking if a socket we got from the parent is suitable for a listener,
|
|
# we just checked that the path matched sockname.tmp, however this is
|
|
# unsuitable for abns sockets, where we don't have to create a temporary
|
|
# file and rename it later.
|
|
# To detect that, check that the first character of the sun_path is 0 for
|
|
# both, and if so, that &sun_path[1] is the same too.
|
|
|
|
varnishtest "Seamless reload issue with abns sockets"
|
|
feature ignore_unknown_macro
|
|
|
|
# abns@ sockets are not available on freebsd
|
|
#EXCLUDE_TARGETS=freebsd,osx,generic
|
|
#REQUIRE_VERSION=1.8
|
|
#REGTEST_TYPE=broken
|
|
|
|
haproxy h1 -W -conf {
|
|
global
|
|
stats socket "${tmpdir}/h1/stats" level admin expose-fd listeners
|
|
|
|
defaults
|
|
mode http
|
|
${no-htx} option http-use-htx
|
|
log global
|
|
option httplog
|
|
timeout connect 1s
|
|
timeout client 1s
|
|
timeout server 1s
|
|
|
|
listen testme
|
|
bind "fd@${testme}"
|
|
server test_abns_server abns@wpproc1 send-proxy-v2
|
|
|
|
frontend test_abns
|
|
bind abns@wpproc1 accept-proxy
|
|
http-request deny deny_status 200
|
|
} -start
|
|
|
|
shell {
|
|
kill -USR2 $(cat "${tmpdir}/h1/pid")
|
|
}
|
|
|
|
client c1 -connect ${h1_testme_sock} {
|
|
txreq -url "/"
|
|
rxresp
|
|
} -repeat 50 -run
|
|
|