mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2024-12-24 05:32:21 +00:00
2c315ee75e
An alignment issue on Sparc64 with ebtrees was reported in early 2017 here https://www.mail-archive.com/haproxy@formilux.org/msg25937.html and a similar one was finally reported in issue #512. The problem has its roots in the fact that 64-bit keys will end up being unaligned on such archs which do not support unaligned accesses. But on most platforms supporting unaligned accesses, dealing with smaller nodes results in better performance. One of the possible problems caused by attribute packed there is that it promotes a structure both to be unaligned and unpadded, which may come with fun if some fields of the struct itself are accessed and such a node is placed at an unaligned location. It's not a problem for regular unaligned accesses but may become one for atomic operations such as the CAS on leaf_p that's used in struct task. In practice we know that this struct is properly aligned and is a very edge case so this patch adds comments there to remind to be careful about it. This patch depends on previous patch "MINOR: compiler: move CPU capabilities definition from config.h and complete them" and could be backported to all stable branches. It fixes issues #512 and #9. |
||
|---|---|---|
| .. | ||
| compiler.h | ||
| eb32sctree.c | ||
| eb32sctree.h | ||
| eb32tree.c | ||
| eb32tree.h | ||
| eb64tree.c | ||
| eb64tree.h | ||
| ebimtree.c | ||
| ebimtree.h | ||
| ebistree.c | ||
| ebistree.h | ||
| ebmbtree.c | ||
| ebmbtree.h | ||
| ebpttree.c | ||
| ebpttree.h | ||
| ebsttree.c | ||
| ebsttree.h | ||
| ebtree.c | ||
| ebtree.h | ||
| LICENSE | ||