mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2025-01-22 05:22:58 +00:00
b1a2faf7c9
Commit a1cc38 introduced a regression which was easy to trigger till ad4cd58
(snapshots 20120222 to 20120311 included). The bug was still present after
that but harder to trigger.
The bug is caused by the use of two distinct log buffers due to intermediary
changes. The issue happens when an HTTP request is logged just after a TCP
request during the same second and the HTTP request is too large for the buffer.
In this case, it happens that the HTTP request is logged into the TCP buffer
instead and that length controls can't detect anything.
Starting with bddd4f, the issue is still possible when logging too large an
HTTP request just after a send_log() call (typically a server status change).
We owe a big thanks to Sander Klein for testing several snapshots and more
specifically for taking significant risks in production by letting the buggy
version crash several times in order to provide an exploitable core ! The bug
could not have been found without this precious help. Thank you Sander !
This fix does not need to be backported, it did not affect any released version.
133 lines
3.6 KiB
C
133 lines
3.6 KiB
C
/*
|
|
include/proto/log.h
|
|
This file contains definitions of log-related functions, structures,
|
|
and macros.
|
|
|
|
Copyright (C) 2000-2008 Willy Tarreau - w@1wt.eu
|
|
|
|
This library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation, version 2.1
|
|
exclusively.
|
|
|
|
This library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with this library; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef _PROTO_LOG_H
|
|
#define _PROTO_LOG_H
|
|
|
|
#include <stdio.h>
|
|
#include <syslog.h>
|
|
|
|
#include <common/config.h>
|
|
#include <common/memory.h>
|
|
#include <types/log.h>
|
|
#include <types/proxy.h>
|
|
#include <types/session.h>
|
|
|
|
extern struct pool_head *pool2_requri;
|
|
|
|
extern char *log_format;
|
|
extern char default_tcp_log_format[];
|
|
extern char default_http_log_format[];
|
|
extern char clf_http_log_format[];
|
|
|
|
|
|
/*
|
|
* send a log for the session when we have enough info about it.
|
|
* Will not log if the frontend has no log defined.
|
|
*/
|
|
void sess_log(struct session *s);
|
|
|
|
/*
|
|
* Parse args in a logformat_var
|
|
*/
|
|
int parse_logformat_var_args(char *args, struct logformat_node *node);
|
|
|
|
/*
|
|
* Parse a variable '%varname' or '%{args}varname' in logformat
|
|
*
|
|
*/
|
|
int parse_logformat_var(char *str, size_t len, struct proxy *curproxy, int *options);
|
|
|
|
/*
|
|
* add to the logformat linked list
|
|
*/
|
|
void add_to_logformat_list(char *start, char *end, int type, struct proxy *curproxy);
|
|
|
|
/*
|
|
* Parse the log_format string and fill a linked list.
|
|
* Variable name are preceded by % and composed by characters [a-zA-Z0-9]* : %varname
|
|
* You can set arguments using { } : %{many arguments}varname
|
|
*/
|
|
void parse_logformat_string(char *str, struct proxy *curproxy);
|
|
|
|
/*
|
|
* Displays the message on stderr with the date and pid. Overrides the quiet
|
|
* mode during startup.
|
|
*/
|
|
void Alert(const char *fmt, ...)
|
|
__attribute__ ((format(printf, 1, 2)));
|
|
|
|
/*
|
|
* Displays the message on stderr with the date and pid.
|
|
*/
|
|
void Warning(const char *fmt, ...)
|
|
__attribute__ ((format(printf, 1, 2)));
|
|
|
|
/*
|
|
* Displays the message on <out> only if quiet mode is not set.
|
|
*/
|
|
void qfprintf(FILE *out, const char *fmt, ...)
|
|
__attribute__ ((format(printf, 2, 3)));
|
|
|
|
/*
|
|
* This function adds a header to the message and sends the syslog message
|
|
* using a printf format string
|
|
*/
|
|
void send_log(struct proxy *p, int level, const char *format, ...)
|
|
__attribute__ ((format(printf, 3, 4)));
|
|
|
|
/*
|
|
* This function sends a syslog message to both log servers of a proxy,
|
|
* or to global log servers if the proxy is NULL.
|
|
* It also tries not to waste too much time computing the message header.
|
|
* It doesn't care about errors nor does it report them.
|
|
*/
|
|
|
|
void __send_log(struct proxy *p, int level, char *message, size_t size);
|
|
|
|
/*
|
|
* returns log level for <lev> or -1 if not found.
|
|
*/
|
|
int get_log_level(const char *lev);
|
|
|
|
/*
|
|
* returns log facility for <fac> or -1 if not found.
|
|
*/
|
|
int get_log_facility(const char *fac);
|
|
|
|
/*
|
|
* Write a string in the log string
|
|
* Take cares of mandatory and quote options
|
|
*
|
|
* Return the adress of the \0 character, or NULL on error
|
|
*/
|
|
char *logformat_write_string(char *dst, char *src, size_t size, struct logformat_node *node);
|
|
|
|
#endif /* _PROTO_LOG_H */
|
|
|
|
/*
|
|
* Local variables:
|
|
* c-indent-level: 8
|
|
* c-basic-offset: 8
|
|
* End:
|
|
*/
|