haproxy/reg-tests
Tim Duesterhus 488ee7fb6e BUG/MAJOR: proxy_protocol: Properly validate TLV lengths
This patch fixes PROXYv2 parsing when the payload of the TCP connection is
fused with the PROXYv2 header within a single recv() call.

Previously HAProxy ignored the PROXYv2 header length when attempting to
parse the TLV, possibly interpreting the first byte of the payload as a
TLV type.

This patch adds proper validation. It ensures that:

1. TLV parsing stops when the end of the PROXYv2 header is reached.
2. TLV lengths cannot exceed the PROXYv2 header length.
3. The PROXYv2 header ends together with the last TLV, not allowing for
   "stray bytes" to be ignored.

A reg-test was added to ensure proper behavior.

This patch tries to find the sweat spot between a small and easily
backportable one, and a cleaner one that's more easily adaptable to
older versions, hence why it merges the "if" and "while" blocks which
causes a reindent of the whole block. It should be used as-is for
versions 1.9 to 2.1, the block about PP2_TYPE_AUTHORITY should be
dropped for 2.0 and the block about CRC32C should be dropped for 1.8.

This bug was introduced when TLV parsing was added. This happened in commit
b3e54fe387. This commit was first released
with HAProxy 1.6-dev1.

A similar issue was fixed in commit 7209c204bd.

This patch must be backported to HAProxy 1.6+.
2020-03-06 11:11:22 +01:00
..
cache REGTEST: rename the reg test files. 2019-04-23 15:37:03 +02:00
checks MINOR: http-ana: Match on the path if the monitor-uri starts by a / 2020-02-18 16:29:29 +01:00
compression REGTESTS: use "command -v" instead of "which" 2020-02-18 14:45:22 +01:00
connection BUG/MAJOR: proxy_protocol: Properly validate TLV lengths 2020-03-06 11:11:22 +01:00
converter MINOR: sample: Validate the number of bits for the sha2 converter 2019-12-17 13:28:00 +01:00
http-capture REGTEST: rename the reg test files. 2019-04-23 15:37:03 +02:00
http-cookies REGTEST: rename the reg test files. 2019-04-23 15:37:03 +02:00
http-errorfiles REGTESTS: Add reg tests for the HTTP return action 2020-02-06 15:13:04 +01:00
http-messaging MINOR: http-htx: Move htx sample fetches in the scope "internal" 2020-01-20 15:18:45 +01:00
http-rules REGTESTS: Add a reg test for http-after-response rulesets 2020-02-06 15:13:04 +01:00
log REGTEST: Wrong assumption in IP:port logging test. 2019-05-07 13:58:35 +02:00
lua REGTEST: adapt some reg tests after renaming. 2019-04-23 15:37:11 +02:00
mailers REGTEST: adapt some reg tests after renaming. 2019-04-23 15:37:11 +02:00
mcli REGTEST: mcli/mcli_start_progs: start 2 programs 2020-01-14 15:42:38 +01:00
peers REGTESTS: Send valid URIs in peers reg-tests and fix HA config to avoid warnings 2019-10-14 22:28:50 +02:00
sample_fetches REGTEST: add sample_fetches/hashes.vtc to validate hashes 2020-01-16 08:45:27 +01:00
seamless-reload REGTEST: vtest can now enable mcli with its own flag 2019-10-30 19:10:04 +01:00
server REGTESTS: server/cli_set_fqdn requires version 1.8 minimum 2019-10-22 13:06:59 +02:00
spoe REGTEST: rename the reg test files. 2019-04-23 15:37:03 +02:00
ssl REGTESTS: make the set_ssl_cert test require version 2.2 2020-01-24 14:29:08 +01:00
stick-table REGTEST: rename the reg test files. 2019-04-23 15:37:03 +02:00
stickiness REGTEST: Add a basic server by name stickiness reg test. 2019-06-05 08:42:36 +02:00
stream REGTEST: Add unique-id reg-test 2020-03-05 07:23:00 +01:00
webstats REGTEST: rename the reg test files. 2019-04-23 15:37:03 +02:00
README REGTEST: Adapt reg test doc files to vtest. 2019-01-14 14:24:29 +01:00

                 * Regression testing for HAProxy with VTest *


This little README file is about how to compile and run vtest test case files (VTC files)
to test HAProxy for any regression.

To do so, you will have to compile vtest program sources which depends on
Varnish cache application sources. vtest, formerly varnishtest, is a very useful
program which has been developed to test Varnish cache application. vtest has been
modified in collaboration with Varnish cache conceptor Poul-Henning Kamp to support
HAProxy in addition to Varnish cache.

See also: doc/regression-testing.txt

* vtest compilation *

    $ git clone https://github.com/vtest/VTest

    $ cd VTest

    $ make vtest

  Then vtest program may be found at the root directory of vtest sources directory.
  The Varnish cache manuals are located in 'man' directory of Varnish cache sources
  directory. You will have to have a look at varnishtest(7) and vtc(7) manuals to
  use vtest.

  Some information may also be found in doc/regression-testing.txt in HAProxy
  sources.

  Note that VTC files for Varnish cache may be found in bin/varnishtest/tests directory
  of Varnish cache sources directory which may be found here:
  https://github.com/varnishcache/varnish-cache


* vtest execution *

  You must set HAPROXY_PROGRAM environment variable to give the location
  of the HAProxy program to test to vtest:

    $ HAPROXY_PROGRAM=<my haproxy program> vtest [-Dno-htx=] ...

  The HAProxy VTC files found in HAProxy sources may be run with the reg-tests
  Makefile target. You must set the VTEST_PROGRAM environment variable to
  give the location of the vtest program which has been previously compiled.

    $ VTEST_PROGRAM=<my vtest program> make reg-tests

  "reg-tests" Makefile target run scripts/run-regtest.sh script.
  To get more information about this script run it with --help option.

  Note that vtest is run with -t10 and -l option. -l option is to keep
  keep vtest temporary directory in case of failed test cases. core files
  may be found in this directory (if enabled by ulimit).


* vtest patches for HAProxy VTC files *

  When producing a patch to add a VTC regression testing file to reg-tests directory,
  please follow these simple rules:

    - If your VTC file needs others files, if possible, use the same basename as that
      of the VTC file,
    - Put these files in a directory with the same name as the code area concerned
      by the bug ('peers', 'lua', 'acl' etc).