haproxy/reg-tests
Christopher Faulet b381a505c1 BUG/MAJOR: tcpcheck: Allocate input and output buffers from the buffer pool
Historically, the input and output buffers of a check are allocated by hand
during the startup, with a specific size (not necessarily the same than
other buffers). But since the recent refactoring of the checks to rely
exclusively on the tcp-checks and to use the underlying mux layer, this part
is totally buggy. Indeed, because these buffers are now passed to a mux,
they maybe be swapped if a zero-copy is possible. In fact, for now it is
only possible in h2_rcv_buf(). Thus the bug concretely only exists if a h2
health-check is performed. But, it is a latent bug for other muxes.

Another problem is the size of these buffers. because it may differ for the
other buffer size, it might be source of bugs.

Finally, for configurations with hundreds of thousands of servers, having 2
buffers per check always allocated may be an issue.

To fix the bug, we now allocate these buffers when required using the buffer
pool. Thus not-running checks don't waste memory and muxes may swap them if
possible. The only drawback is the check buffers have now always the same
size than buffers used by the streams. This deprecates indirectly the
"tune.chksize" global option.

In addition, the http-check regtest have been update to perform some h2
health-checks.

Many thanks to @VigneshSP94 for its help on this bug.

This patch should solve the issue #936. It relies on the commit "MINOR:
tcpcheck: Don't handle anymore in-progress send rules in tcpcheck_main".
Both must be backport as far as 2.2.

bla
2020-11-27 10:29:41 +01:00
..
balance REGTEST: fix host part in balance-uri-path-only.vtc 2020-09-29 10:52:27 +02:00
cache MINOR: cache: Add a process-vary option that can enable/disable Vary processing 2020-11-24 16:52:57 +01:00
checks BUG/MAJOR: tcpcheck: Allocate input and output buffers from the buffer pool 2020-11-27 10:29:41 +01:00
compression REGTESTS: Add missing OPENSSL to REQUIRE_OPTIONS for compression/lua_validation 2020-05-26 13:36:30 +02:00
connection REGTESTS: mark proxy_protocol_random_fail as broken 2020-11-21 15:33:03 +01:00
converter REGTESTS: converter: add url_dec test 2020-11-17 11:53:25 +01:00
filters REGTESTS: Add a script to test the random forwarding with several filters 2020-11-17 11:34:36 +01:00
http-capture
http-cookies MEDIUM: proxy: remove start_proxies() 2020-10-09 11:27:30 +02:00
http-errorfiles BUG/MINOR: http-rules: Fix ACLs parsing for http deny rules 2020-06-30 09:32:03 +02:00
http-messaging CLEANUP: assorted typo fixes in the code and comments 2020-06-26 11:27:28 +02:00
http-rules MINOR: http_act: Add -m flag for del-header name matching method 2020-11-21 15:54:30 +01:00
log MEDIUM: proxy: remove start_proxies() 2020-10-09 11:27:30 +02:00
lua MEDIUM: proxy: remove start_proxies() 2020-10-09 11:27:30 +02:00
mailers CLEANUP: assorted typo fixes in the code and comments 2020-03-14 09:42:07 +01:00
mcli REGTEST: mcli/mcli_start_progs: start 2 programs 2020-01-14 15:42:38 +01:00
peers
sample_fetches REGTESTS: Add sample_fetches/cook.vtc 2020-11-13 19:46:15 +01:00
seamless-reload REGTESTS: mark the abns test as broken again 2020-11-17 11:45:10 +01:00
server REGTEST: server/cli_set_ssl.vtc requires OpenSSL 2020-11-18 17:41:28 +01:00
spoe CLEANUP: assorted typo fixes in the code and comments 2020-03-14 09:42:07 +01:00
ssl REGTEST: make ssl_client_samples and ssl_server_samples require to 2.2 2020-11-13 17:12:30 +01:00
stick-table REGTEST: remove stray leading spaces in converteers_ref_cnt_never_dec.vtc 2020-08-19 11:20:28 +02:00
stickiness
stream REGTEST: make the unique-id test depend on version 2.0 2020-04-01 16:08:43 +02:00
webstats
README

                 * Regression testing for HAProxy with VTest *


This little README file is about how to compile and run vtest test case files (VTC files)
to test HAProxy for any regression.

To do so, you will have to compile vtest program sources which depends on
Varnish cache application sources. vtest, formerly varnishtest, is a very useful
program which has been developed to test Varnish cache application. vtest has been
modified in collaboration with Varnish cache conceptor Poul-Henning Kamp to support
HAProxy in addition to Varnish cache.

See also: doc/regression-testing.txt

* vtest compilation *

    $ git clone https://github.com/vtest/VTest

    $ cd VTest

    $ make vtest

  Then vtest program may be found at the root directory of vtest sources directory.
  The Varnish cache manuals are located in 'man' directory of Varnish cache sources
  directory. You will have to have a look at varnishtest(7) and vtc(7) manuals to
  use vtest.

  Some information may also be found in doc/regression-testing.txt in HAProxy
  sources.

  Note that VTC files for Varnish cache may be found in bin/varnishtest/tests directory
  of Varnish cache sources directory which may be found here:
  https://github.com/varnishcache/varnish-cache


* vtest execution *

  You must set HAPROXY_PROGRAM environment variable to give the location
  of the HAProxy program to test to vtest:

    $ HAPROXY_PROGRAM=<my haproxy program> vtest [-Dno-htx=] ...

  The HAProxy VTC files found in HAProxy sources may be run with the reg-tests
  Makefile target. You must set the VTEST_PROGRAM environment variable to
  give the location of the vtest program which has been previously compiled.

    $ VTEST_PROGRAM=<my vtest program> make reg-tests

  "reg-tests" Makefile target run scripts/run-regtest.sh script.
  To get more information about this script run it with --help option.

  Note that vtest is run with -t10 and -l option. -l option is to keep
  keep vtest temporary directory in case of failed test cases. core files
  may be found in this directory (if enabled by ulimit).


* vtest patches for HAProxy VTC files *

  When producing a patch to add a VTC regression testing file to reg-tests directory,
  please follow these simple rules:

    - If your VTC file needs others files, if possible, use the same basename as that
      of the VTC file,
    - Put these files in a directory with the same name as the code area concerned
      by the bug ('peers', 'lua', 'acl' etc).