mirror of
http://git.haproxy.org/git/haproxy.git/
synced 2025-01-05 11:39:33 +00:00
efde955bdb
When the metrics are dumped, in the main function promex_dump_metrics(), the appctx flags are set before entering in a new scope, among others things to know which metrics names and descriptions to use. But, those flags are not restored when the dump is interrupted because of a full output buffer. If this happens after the dump of global metrics, it may only lead to extra #TYPE and #HELP lines. But if this happens during the dump of global metrics, the following dumps of frontends, backends and servers metrics use names and descriptions of global ones with the unmatching indexes. This first leads to unexisting metrics names. For instance, "haproxy_frontend_nbproc". But also to out-of-bound accesses to name and description arrays because there are more stats fields than info fields. It is easy to reproduce the bug using small buffers, setting tune.bufsize to 8192 for instance. This patch should fix the issue #666. It must be backported as far as 2.0. |
||
|---|---|---|
| .. | ||
| 51d/src | ||
| base64 | ||
| debug | ||
| deviceatlas | ||
| halog | ||
| hpack | ||
| ip6range | ||
| iprange | ||
| mod_defender | ||
| modsecurity | ||
| netsnmp-perl | ||
| plug_qdisc | ||
| prometheus-exporter | ||
| selinux | ||
| spoa_example | ||
| spoa_server | ||
| syntax-highlight | ||
| systemd | ||
| tcploop | ||
| trace | ||
| wireshark-dissectors/peers | ||
| wurfl | ||