From fff96b441f73195f1407c38ba2ad7d904a6458f4 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 19 Apr 2021 07:49:50 +0200 Subject: [PATCH] CLEANUP: pools: remove unused arguments to pool_evict_from_cache() In commit fb117e6a8 ("MEDIUM: memory: don't let pool_put_to_cache() free the objects itself") pool_evict_from_cache() was introduced with no argument, yet the only call place passes it the pool, the pointer and the index number! Let's remove these as they even let the reader think that the function does something specific to the current pool while it's not the case. --- include/haproxy/pool.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/haproxy/pool.h b/include/haproxy/pool.h index e0e03fc32..b9865a2b5 100644 --- a/include/haproxy/pool.h +++ b/include/haproxy/pool.h @@ -139,7 +139,7 @@ static inline void pool_put_to_cache(struct pool_head *pool, void *ptr, ssize_t pool_cache_bytes += ph->size; if (unlikely(pool_cache_bytes > CONFIG_HAP_POOL_CACHE_SIZE)) - pool_evict_from_cache(pool, ptr, idx); + pool_evict_from_cache(); } #else // CONFIG_HAP_LOCAL_POOLS