RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-05-05 17:28:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: h3: fix compiler warning variable set but not used

Browse Source 
Some variables were only checked via BUG_ON macro. If compiling without
DEBUG_STRICT, this instruction is a noop. Fix this by using an explicit
condition + ABORT_NOW.

This should fix the github issue #1549.
This commit is contained in:
Amaury Denoyelle 2022-02-21 18:38:29 +01:00
parent d1c76f24fd
commit ff191de1ca
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/h3.c
View File

@ -211,11 +211,14 @@ static int h3_data_to_htx(struct qcs *qcs, struct buffer *buf, uint64_t len,
htx = htx_from_buf(appbuf);
htx_space = htx_free_data_space(htx);
BUG_ON(!htx_space || htx_space < len);
if (!htx_space || htx_space < len) {
ABORT_NOW(); /* TODO handle this case properly */
}
htx_sent = htx_add_data(htx, ist2(b_head(buf), len));
/* TODO handle full appbuf */
BUG_ON(htx_sent < len);
if (htx_sent < len) {
ABORT_NOW(); /* TODO handle this case properly */
}
if (fin)
htx->flags |= HTX_FL_EOM;
@ -264,12 +267,12 @@ static int h3_decode_qcs(struct qcs *qcs, int fin, void *ctx)
case H3_FT_DATA:
ret = h3_data_to_htx(qcs, rxbuf, flen, last_stream_frame);
/* TODO handle error reporting. Stream closure required. */
BUG_ON(ret);
if (ret) { ABORT_NOW(); }
break;
case H3_FT_HEADERS:
ret = h3_headers_to_htx(qcs, rxbuf, flen, last_stream_frame);
/* TODO handle error reporting. Stream closure required. */
BUG_ON(ret);
if (ret) { ABORT_NOW(); }
break;
case H3_FT_PUSH_PROMISE:
/* Not supported */