From fd7426726414e4b05bbf4f0bacbd86db1e1dee75 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Mon, 18 Feb 2019 11:22:35 +0100 Subject: [PATCH] BUG/MINOR: mux-h2: Don't add ":status" pseudo-header on trailers It is a cut-paste bug. Pseudo-header fields MUST NOT appear in trailers. This patch must be backported to 1.9. --- src/mux_h2.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mux_h2.c b/src/mux_h2.c index 9b50f7ecab..62b8b00144 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -4933,13 +4933,6 @@ static size_t h2s_htx_make_trailers(struct h2s *h2s, struct htx *htx) write_n32(outbuf.area + 5, h2s->id); // 4 bytes outbuf.data = 9; - /* encode status, which necessarily is the first one */ - if (!hpack_encode_int_status(&outbuf, h2s->status)) { - if (b_space_wraps(&h2c->mbuf)) - goto realign_again; - goto full; - } - /* encode all headers */ for (idx = 0; idx < hdr; idx++) { /* these ones do not exist in H2 or must not appear in