RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-23 14:16:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MAJOR: dns: first DNS response packet not matching queried hostname may lead to a loop

Browse Source 
The status DNS_UPD_NAME_ERROR returned by dns_get_ip_from_response and
which means the queried name can't be found in the response was
improperly processed (fell into the default case).
This lead to a loop where HAProxy simply resend a new query as soon as
it got a response for this status and in the only case where such type
of response is the very first one received by the process.

This should be backported into 1.6 branch
This commit is contained in:
Baptiste Assmann 2015-10-28 02:03:32 +01:00 committed by Willy Tarreau
parent f2dd5e4159
commit fad0318c74
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/server.c
View File

@ -2620,6 +2620,17 @@ int snr_resolution_cb(struct dns_resolution *resolution, struct dns_nameserver *
}
goto stop_resolution;
case DNS_UPD_NAME_ERROR:
/* if this is not the last expected response, we ignore it */
if (resolution->nb_responses < nameserver->resolvers->count_nameservers)
return 0;
/* update resolution status to OTHER error type */
if (resolution->status != RSLV_STATUS_OTHER) {
resolution->status = RSLV_STATUS_OTHER;
resolution->last_status_change = now_ms;
}
goto stop_resolution;
default:
goto invalid;