RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-01 11:01:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

CLEANUP: map, stream: remove duplicate code in src/map.c, src/stream.c

Browse Source 
issue was identified by cppcheck

[src/map.c:372] -> [src/map.c:376]: (warning) Variable 'appctx->st2' is reassigned a value before the old one has been used. 'break;' missing?
[src/map.c:433] -> [src/map.c:437]: (warning) Variable 'appctx->st2' is reassigned a value before the old one has been used. 'break;' missing?
[src/map.c:555] -> [src/map.c:559]: (warning) Variable 'appctx->st2' is reassigned a value before the old one has been used. 'break;' missing?
[src/stream.c:3264] -> [src/stream.c:3268]: (warning) Variable 'appctx->st2' is reassigned a value before the old one has been used. 'break;' missing?

Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
This commit is contained in:
Ilya Shipitsin 2018-03-23 17:41:48 +05:00 committed by Willy Tarreau
parent fe234281d6
commit f93f0935c9
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/map.c
View File

@ -369,7 +369,6 @@ static int cli_io_handler_pat_list(struct appctx *appctx)
appctx->ctx.map.bref.ref = elt->list.n;
}
HA_SPIN_UNLOCK(PATREF_LOCK, &appctx->ctx.map.ref->lock);
appctx->st2 = STAT_ST_FIN;
/* fall through */
default:
@ -430,7 +429,6 @@ static int cli_io_handler_pats_list(struct appctx *appctx)
appctx->ctx.map.display_flags);
}
appctx->st2 = STAT_ST_FIN;
/* fall through */
default:
@ -552,7 +550,6 @@ static int cli_io_handler_map_lookup(struct appctx *appctx)
&appctx->ctx.map.ref->pat);
}
HA_SPIN_UNLOCK(PATREF_LOCK, &appctx->ctx.map.ref->lock);
appctx->st2 = STAT_ST_FIN;
/* fall through */
default:

1
src/stream.c
View File

@ -3261,7 +3261,6 @@ static int cli_io_handler_dump_sess(struct appctx *appctx)
}
HA_SPIN_UNLOCK(STRMS_LOCK, &streams_lock);
appctx->st2 = STAT_ST_FIN;
/* fall through */
default: