RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-27 16:11:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: server: remove idle lock in srv_cleanup_connections

Browse Source 
This function used to grab the idle lock when scanning the threads for
idle connections, but it doesn't need it since the lock only protects
the tree. Let's remove it.
This commit is contained in:
Willy Tarreau 2020-11-06 12:07:31 +01:00
parent 70d10d1fb6
commit f5fe70620c
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/server.c
View File

@ -5222,7 +5222,6 @@ static void srv_cleanup_connections(struct server *srv)
int i;
/* check all threads starting with ours */
HA_SPIN_LOCK(OTHER_LOCK, &idle_conn_srv_lock);
for (i = tid;;) {
did_remove = 0;
if (srv_migrate_conns_to_remove(&srv->idle_conns[i], &idle_conns[i].toremove_conns, -1) > 0)
@ -5235,7 +5234,6 @@ static void srv_cleanup_connections(struct server *srv)
if ((i = ((i + 1 == global.nbthread) ? 0 : i + 1)) == tid)
break;
}
HA_SPIN_UNLOCK(OTHER_LOCK, &idle_conn_srv_lock);
}
struct task *srv_cleanup_idle_connections(struct task *task, void *context, unsigned short state)