RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-03-11 05:48:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

CLEANUP: startup: make if condition to kill old pids more readable

Browse Source 
Update comment and condition. nb_oldpids it's not a pointer, but a signed int,
which keeps the max number of elements in oldpids array. So, it's a good
practice to check, if it's strictly positive here.
This commit is contained in:
Valentine Krasnobaeva 2024-12-03 21:13:29 +01:00 committed by William Lallemand
parent cd0b58e23e
commit f24e57d717
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/haproxy.c
View File

@ -3552,10 +3552,15 @@ int main(int argc, char **argv)
ha_free(&global.chroot);
/* In master-worker mode master sends TERM to previous workers up to
* receiving status READY
/* In standalone mode send USR1/TERM to the previous worker,
* launched with -sf $(cat pidfile).
* In master-worker mode, see _send_status(): master process sends
* USR1/TERM to previous workers up to receiving status READY from the
* worker, which is newly forked. Then master sends USR1 or TERM to previous
* master, if it was launched with (-W -D -sf $(cat pidfile).
*/
if (!(global.mode & MODE_MWORKER) && nb_oldpids) {
if (!(global.mode & MODE_MWORKER) && (nb_oldpids > 0)) {
nb_oldpids = tell_old_pids(oldpids_sig);
}