RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: mux-h2: Don't send RST_STREAM frame for streams with no ID 

On server side, the H2 stream is first created with an unassigned ID (ID ==
0). Its ID is assigned when the request is emitted, before formatting the
HEADERS frame. However, the session may be aborted during that stage. We
must take care to not emit RST_STREAM frame for this stream, because it does
not exist yet for the server.

It is especially important to do so because, depending on the timing, it may
also happens before the H2 PREFACE was sent.

This patch must be backported to all stable versions. It is related to issue
This commit is contained in:
Christopher Faulet 2024-11-15 10:25:20 +01:00
parent 4fd6d15344
commit f065d00098
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mux_h2.c
View File

@ -2366,8 +2366,10 @@ static int h2s_send_rst_stream(struct h2c *h2c, struct h2s *h2s)
/* RFC7540#5.4.2: To avoid looping, an endpoint MUST NOT send a /* RFC7540#5.4.2: To avoid looping, an endpoint MUST NOT send a
* RST_STREAM in response to a RST_STREAM frame. * RST_STREAM in response to a RST_STREAM frame.
*
* if h2s is not assigned yet (id == 0), don't send a RST_STREAM frame.
*/ */
if (h2c->dsi == h2s->id && h2c->dft == H2_FT_RST_STREAM) { if ((h2s->id == 0) || (h2c->dsi == h2s->id && h2c->dft == H2_FT_RST_STREAM)) {
ret = 1; ret = 1;
goto ignore; goto ignore;
} }