RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-03-10 05:21:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: quic: Too much reduced computed space to build handshake packets

Browse Source 
Before this patch we reserved 16 bytes (QUIC_TLS_TAG_LEN) before building the
handshake packet to be sure to be able to add the tag which comes with the
the packet encryption, decreasing the end offset of the building buffer by 16 bytes.
But this tag length was taken into an account when calling qc_build_frms() which
computes and build crypto frames for the remaining available room thanks to <*len>
parameter which is the length of the already present bytes in the building buffer
before adding CRYPTO frames. This leaded us to waste the 16 last bytes of the buffer
which were not used.
This commit is contained in:
Frédéric Lécaille 2021-07-02 17:20:04 +02:00 committed by Amaury Denoyelle
parent 82d1daa268
commit ed9119f39e
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xprt_quic.c
View File

@ -3662,8 +3662,6 @@ static ssize_t qc_do_build_hdshk_pkt(struct q_buf *wbuf,
goto err;
}
/* Reserve enough room at the end of the packet for the AEAD TAG. */
end -= QUIC_TLS_TAG_LEN;
largest_acked_pn = qel->pktns->tx.largest_acked_pn;
/* packet number length */
*pn_len = quic_packet_number_length(pn, largest_acked_pn);