RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-01 22:48:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: stconn: Schedule a shutw on shutr if data must be sent first

Browse Source 
The commit 7f59d68fe ("BUG/MEDIIM: stconn: Flush output data before
forwarding close to write side") introduced a regression. When the read side
is closed, the close is not forwarded to the write side if there are some
pending outgoind data. The idea is to foward data first and the close the
write side. However, when fast-forwarding is enabled and last data block is
received with the read0, the close is never forwarded.

We cannot revert the commit above because it really fix an issue. However,
we can schedule the shutdown for write by setting CF_SHUTW_NOW flag on the
write side. Indeed, it is the purpose of this flag.

To not replicate ugly and hardly maintainable code block at different places
in stconn.c, an helper function is used. Thus, sc_cond_forward_shutw() must
be called to know if the close can be fowarded or not. It returns 1 if it is
possible. In this case, the caller is responsible to forward the close to
the write side. Otherwise, if the close cannot be forwarded, 0 is
returned. It happens when it should not be performed at all. Or when it
should only be delayed, waiting for the input channel to be flushed. In this
last case, the CF_SHUTW_NOW flag is set in the output channel.

This patch should fix the issue #2033. It must be backported with the commit
above, thus at least as far as 2.2.
This commit is contained in:
Christopher Faulet 2023-02-08 16:18:48 +01:00
parent 86207e782c
commit eb3f26d5a0
1 changed files with 28 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/stconn.c
View File

@ -494,6 +494,30 @@ struct appctx *sc_applet_create(struct stconn *sc, struct applet *app)
return appctx;
}
/* Conditionnaly forward the close to the wirte side. It return 1 if it can be
* forwarded. It is the caller responsibility to forward the close to the write
* side. Otherwise, 0 is returned. In this case, CF_SHUTW_NOW flag may be set on
* the channel if we are only waiting for the outgoing data to be flushed.
*/
static inline int sc_cond_forward_shutw(struct stconn *sc)
{
/* The close must not be forwarded */
if (!(sc_ic(sc)->flags & CF_SHUTR) || !(sc->flags & SC_FL_NOHALF))
return 0;
if (!channel_is_empty(sc_ic(sc))) {
/* the close to the write side cannot be forwarded now because
* we should flush outgoing data first. But instruct the output
* channel it should be done ASAP.
*/
channel_shutw_now(sc_oc(sc));
return 0;
}
/* the close can be immediately forwarded to the write side */
return 1;
}
/*
* This function performs a shutdown-read on a detached stream connector in a
* connected or init state (it does nothing for other states). It either shuts
@ -518,10 +542,8 @@ static void sc_app_shutr(struct stconn *sc)
if (sc->flags & SC_FL_ISBACK)
__sc_strm(sc)->conn_exp = TICK_ETERNITY;
}
else if ((sc->flags & SC_FL_NOHALF) && channel_is_empty(ic)) {
/* we want to immediately forward this close to the write side */
else if (sc_cond_forward_shutw(sc))
return sc_app_shutw(sc);
}
/* note that if the task exists, it must unregister itself once it runs */
if (!(sc->flags & SC_FL_DONT_WAKE))
@ -662,10 +684,8 @@ static void sc_app_shutr_conn(struct stconn *sc)
if (sc->flags & SC_FL_ISBACK)
__sc_strm(sc)->conn_exp = TICK_ETERNITY;
}
else if ((sc->flags & SC_FL_NOHALF) && channel_is_empty(ic)) {
/* we want to immediately forward this close to the write side */
else if (sc_cond_forward_shutw(sc))
return sc_app_shutw_conn(sc);
}
}
/*
@ -890,10 +910,8 @@ static void sc_app_shutr_applet(struct stconn *sc)
if (sc->flags & SC_FL_ISBACK)
__sc_strm(sc)->conn_exp = TICK_ETERNITY;
}
else if ((sc->flags & SC_FL_NOHALF) && channel_is_empty(ic)) {
/* we want to immediately forward this close to the write side */
else if (sc_cond_forward_shutw(sc))
return sc_app_shutw_applet(sc);
}
}
/*
@ -1253,7 +1271,7 @@ static void sc_conn_read0(struct stconn *sc)
if (oc->flags & CF_SHUTW)
goto do_close;
if ((sc->flags & SC_FL_NOHALF) && channel_is_empty(ic)) {
if (sc_cond_forward_shutw(sc)) {
/* we want to immediately forward this close to the write side */
/* force flag on ssl to keep stream in cache */
sc_conn_shutw(sc, CO_SHW_SILENT);