From e7bbbca781e72a6c96fcaa8601637f5cfcacb920 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 30 Aug 2019 15:02:22 +0200 Subject: [PATCH] BUG/MEDIUM: mux-h2/trace: fix missing braces added with traces Ilya reported in issue #242 that h2c_handle_priority() was having unreachable code... Obviously, I missed the braces around the "if", leaving an unconditional return. No backport is needed. --- src/mux_h2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mux_h2.c b/src/mux_h2.c index f4ab7c671..a815b6b11 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -2305,9 +2305,10 @@ static int h2c_handle_priority(struct h2c *h2c) TRACE_ENTER(H2_EV_RX_FRAME|H2_EV_RX_PRIO, h2c->conn); /* process full frame only */ - if (b_data(&h2c->dbuf) < h2c->dfl) + if (b_data(&h2c->dbuf) < h2c->dfl) { TRACE_DEVEL("leaving on missing data", H2_EV_RX_FRAME|H2_EV_RX_PRIO, h2c->conn); return 0; + } if (h2_get_n32(&h2c->dbuf, 0) == h2c->dsi) { /* 7540#5.3 : can't depend on itself */