RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-13 23:14:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: connection: local_send_proxy must wait for connection to establish

Browse Source 
The conn_local_send_proxy() function has to retrieve the local and remote
addresses, but the getpeername() and getsockname() functions may fail until
the connection is established. So now we catch this error and poll for write
when this happens.
This commit is contained in:
Willy Tarreau 2012-11-24 11:23:04 +01:00
parent 6c560da279
commit e3635edc88
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/connection.c
View File

@ -531,14 +531,16 @@ int conn_local_send_proxy(struct connection *conn, unsigned int flag)
if (conn->flags & CO_FL_SOCK_WR_SH)
goto out_error;
/* The target server expects a PROXY line to be sent first. */
/* The target server expects a PROXY line to be sent first. Retrieving
* local or remote addresses may fail until the connection is established.
*/
conn_get_from_addr(conn);
if (!(conn->flags & CO_FL_ADDR_FROM_SET))
goto out_error;
goto out_wait;
conn_get_to_addr(conn);
if (!(conn->flags & CO_FL_ADDR_TO_SET))
goto out_error;
goto out_wait;
trash.len = make_proxy_line(trash.str, trash.size, &conn->addr.from, &conn->addr.to);
if (!trash.len)