RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-01 02:52:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert: MEDIUM: evports: permit to report multiple events at once"

Browse Source 
Tests have shown that switching nevlist to global.tune.maxpollevents
is totally unreliable when using evports, and that events seem to be
missed. A good reproducer seems to be QUIC. There are not enough
users of Solaris to warrant spending more time trying to get down to
this, and even the few that remain are by definition not interested
in performance, so let's just revert the commit that tried to lift the
value: e6662bf706 ("MEDIUM: evports: permit to report multiple events
at once").

No backport is needed.
This commit is contained in:
Willy Tarreau 2024-05-17 15:53:40 +02:00
parent 0999e3d959
commit e362b076b1
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ev_evports.c
View File

@ -185,7 +185,15 @@ static void _do_poll(struct poller *p, int exp, int wake)
do {
int timeout = (global.tune.options & GTUNE_BUSY_POLLING) ? 0 : wait_time;
int interrupted = 0;
nevlist = global.tune.maxpollevents; /* desired number of events to be retrieved */
/* Note: normally we should probably expect to pass
* global.tune.maxpollevents here so as to process multiple
* events at once, but it appears unreliable in tests, even
* starting with value 2, and it seems basically nobody's
* using that anymore so it's probably not worth spending days
* investigating this poller more to improve its performance,
* let's switch back to 1. --WT
*/
nevlist = 1; /* desired number of events to be retrieved */
timeout_ts.tv_sec = (timeout / 1000);
timeout_ts.tv_nsec = (timeout % 1000) * 1000000;