RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-11 05:54:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: proxy: always initialize the trash in show servers state

Browse Source 
Actually the cleanup in commit 6ff8143f7 ("BUG/MINOR: proxy: fix
dump_server_state()'s misuse of the trash") allowed to spot that the
trash is never reset when dumping a servers state. I couldn't manage
to make it dump garbage even with large setups but didn't find either
where it's cleared between successive calls while other handlers do
explicitly invoke chunk_reset(), so it seems to happen a bit by luck.

Let's use chunk_printf() here for each turn, it makes things clearer.

This could be backported along with previous patch, especially if any
user reports occasional garbage appearing in the show servers output.
This commit is contained in:
Willy Tarreau 2020-07-01 07:09:39 +02:00
parent 6ff8143f7c
commit df2a0305f2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/proxy.c
View File

@ -1794,7 +1794,7 @@ static int dump_servers_state(struct stream_interface *si)
if (srv->srvrq && srv->srvrq->name)
srvrecord = srv->srvrq->name;
chunk_appendf(&trash,
chunk_printf(&trash,
"%d %s "
"%d %s %s "
"%d %d %d %d %ld "